Problem/Motivation
The XML Items Wrapper is required but does not accept variables. But we might want/need to use variables in the XML Items Wrapper
Proposed resolution
Allow variables in all tags.
As a workaround Remove XML Items Wrapper from required fields list. This allows to leave the field empty and move the tag to the body where we can use variables, https://git.drupalcode.org/project/xmlfeedviews/-/blob/1.2.3-beta6/src/P...
Testing suggests it works.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3334171-2-combine-3325192-3308396.patch | 3.88 KB | anruether |
Comments
Comment #2
anruetherThis patch combines this issue and
Comment #3
geek-merlinFor the maintainer it is better to have a single patch that can be reviewed.
(Of course sometimes it is convenient to combine patches, but then better hide them for the summary, to not create confution.)
Also, creating a MR is simple nowadays and makes it easier for the maintainer: It's just one click.
Comment #4
geek-merlinI don't get it: Is this a duplicate of the other issue? Then you should update status für anti-chaos and good karma.
Comment #5
anruetherNo, those are two different issues. The linked issue deals with the body field (you can use one var per line without the patch), while this one deals with the XML Items Wrapper fields where you cannot use any number of vars.
Comment #7
admirernepali commentedComment #8
vasyok commentedSorry, I don't understand how to use Twig variables in wrappers.
I add to XML Items Wrapper

<offer id="{{ nid }}">but it's dosn't work, result code stiil not catch variable:

Comment #9
vasyok commented