Problem/Motivation

Text in the 'Privacy info' text, and actually all text in mytube-instance.tpl.php will get umlauts like äüö mangled e.g. instead of 'ü' will be displayed 'ü'

Steps to reproduce

put 'Ihre IP-Adresse wird hierbei an !domain übermittelt.' in the 'Privacy info' text field

Proposed resolution

$out = new DOMDocument('1.0', 'UTF-8');
$out->loadHTML(mb_convert_encoding(theme('mytube_instance', $variables), 'HTML-ENTITIES', 'UTF-8'));

worked as a remedy

CommentFileSizeAuthor
#9 3333597-9.patch2.11 KBmfb
#6 3333597-6.patch2.07 KBmfb
#4 3333597-test-only.patch1.44 KBmfb
#3 3333597.patch646 bytesmfb

Comments

a8w4 created an issue. See original summary.

mfb’s picture

mfb
they or he
commented
Issue tags: +Needs tests

@a8w4 What version of PHP are you using? We should write a test for this case.

mfb’s picture

mfb
they or he
commented
Status: Active » Needs review
StatusFileSize
new 3333597.patch646 bytes

It looks like using the Drupal APIs for manipulating HTML properly should resolve this.

mfb’s picture

mfb
they or he
commented
StatusFileSize
new 3333597-test-only.patch1.44 KB

Status: Needs review » Needs work

The last submitted patch, 4: 3333597-test-only.patch, failed testing. View results

mfb’s picture

mfb
they or he
commented
Status: Needs work » Needs review
StatusFileSize
new 3333597-6.patch2.07 KB

  • mfb committed be573313 on 7.x-1.x 
    Issue #3333597 by mfb, a8w4:  umlauts like äüö get mangled
mfb’s picture

mfb
they or he
commented
Version: 7.x-1.3 » 8.x-1.x-dev
Status: Needs review » Patch (to be ported)

Looks like we also need to port this to 8.x-1.x

Idk when PHP will finally default to UTF-8 HTML.. but luckily we can just use Drupal APIs..

mfb’s picture

mfb
they or he
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 3333597-9.patch2.11 KB

  • mfb committed 1e3e4f98 on 8.x-1.x 
    Issue #3333597 by mfb, a8w4:  umlauts like äüö get mangled
mfb’s picture

mfb
they or he
commented
Status: Needs review » Fixed
Issue tags: -Needs tests

Thanks for reporting!

a8w4’s picture

a8w4
Location Frankfurt am Main
commented

That's correct - it works this way - genius!
Thank you @mfb for this lightning-fast fix - no need anymore to use a contrib-module with changes - great!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.