Problem/Motivation
PHPStan 1.9.9 was released.
Looking at the "updated deps" TestBot runs lately we can see it apparently fixes two false negatives:
Running PHPStan on *all* files.
------ --------------------------------------------------------------------
Line core/lib/Drupal/Component/Utility/Color.php
------ --------------------------------------------------------------------
Ignored error pattern #^Variable \$rgb might not be defined\.$# in
path /var/www/html/core/lib/Drupal/Component/Utility/Color.php was
not matched in reported errors.
------ --------------------------------------------------------------------
------ -----------------------------------------------------------------------
Line core/modules/system/tests/src/Functional/Form/CheckboxTest.php
------ -----------------------------------------------------------------------
Ignored error pattern #^Variable \$checked might not be defined\.$#
in path
/var/www/html/core/modules/system/tests/src/Functional/Form/CheckboxT
est.php was not matched in reported errors.
------ -----------------------------------------------------------------------
[ERROR] Found 2 errors
PHPStan: failed
Note: IN the meantime PHPStan released 1.9.11, I checked, but there are no other false negatives removed, so we can stick with version 1.9.9.
Steps to reproduce
Proposed resolution
- Update phpstan/phpstan to 1.9.9
- Create a new baseline
- Bump version of PHPStan in composer.json to 1.9.9, since the newly created baseline won't pass on 1.9.3
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3333065-2.patch | 4.55 KB | spokje |
Comments
Comment #2
spokjeComment #3
spokjeComment #4
spokjeComment #5
spokjeComment #6
spokjeComment #7
mondrake👍
Comment #8
spokjeComment #9
longwaveCommitted to 10.1.x and 10.0.x, thanks! This would not cherry-pick cleanly for me so I committed separately, also I noticed that composer.json has an extra blank line in 10.0.x vs 10.1.x so I will open an issue to tidy that up.
Comment #10
longwave