PHPCS reported the following Errors and warnings:

FILE: /revision_graph/js/revision_graph.js
----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
 17 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------


FILE: /revision_graph/src/Controller/RevisionGraphNodeController.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------
  95 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
 124 | WARNING | [ ] Unused variable $langcode.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------


FILE: /revision_graph/src/RevisionGraphStorage.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 2 WARNINGS AFFECTING 7 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
  9 | ERROR   | [x] Missing class doc comment
 40 | ERROR   | [x] Missing function doc comment
 50 | ERROR   | [x] Missing function doc comment
 51 | WARNING | [x] '@TODO hunt actual parent version id.' should match the format '@todo Fix problem X here.'
 57 | WARNING | [x] '@TODO Check if this is a bug in core due to some optimisation.' should match the format '@todo Fix problem X here.'
 81 | ERROR   | [x] Missing function doc comment
 86 | ERROR   | [x] Missing function doc comment
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /revision_graph/src/RevisionGraphProcess.php
------------------------------------------------------------------------------------------------------------
FOUND 31 ERRORS AND 3 WARNINGS AFFECTING 32 LINES
------------------------------------------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
  6 | WARNING | [x] Unused use statement
 14 | ERROR   | [x] Opening brace should be on the same line as the declaration
 15 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 16 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 17 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 19 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 22 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 23 | ERROR   | [x] Opening brace should be on the same line as the declaration
 24 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 25 | ERROR   | [x] Object operator not indented correctly; expected 10 spaces but found 8
 26 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 27 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 27 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 28 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 29 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 31 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 32 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 33 | ERROR   | [x] Object operator not indented correctly; expected 14 spaces but found 16
 34 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 35 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 37 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 40 | ERROR   | [x] Expected "int|null" but found "integer|null" for function return type
 43 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 44 | ERROR   | [x] Opening brace should be on the same line as the declaration
 45 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 45 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
 46 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 47 | ERROR   | [x] Object operator not indented correctly; expected 10 spaces but found 8
 48 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 50 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 51 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 52 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 53 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 33 MARKED SNIFF VIOLATIONS AUTOMATICALLY
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

SolimanHarkas created an issue. See original summary.

solimanharkas’s picture

Assigned: solimanharkas » Unassigned
Issue tags: +phpcs

Please review my merge request, thank you

_pratik_ made their first commit to this issue’s fork.

_pratik_’s picture

Status: Active » Needs review
jay jangid’s picture

Assigned: Unassigned » jay jangid

I will review this patch.

jay jangid’s picture

Assigned: jay jangid » Unassigned
Status: Needs review » Reviewed & tested by the community

Thanks @_pratik_ for MR.Its working properly.
Result:-Fix PHPCS errors and warnings.
Move to RTBC+

  • D34dMan committed 1ad4303c on 2.0.x
    Issue #3331023 by SolimanHarkas, _pratik_, Jay Jangid, D34dMan: Fix...
d34dman’s picture

Issue tags: - +ContributionWeekend2024

Thanks for the contribution.

d34dman’s picture

Status: Reviewed & tested by the community » Fixed
d34dman’s picture

Just a note for the future

17 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"

This was false warning and fixing that broke the JavaScript code, because 'FALSE' is invalid in JavaScript.

This was fixed in 2.1.2 release that was made recently.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.