Problem/Motivation

I'm pretty sure that in #3328351: Explicit access checks on content entity queries, we went a bit to far. We need to back out the accessCheck on the membership loader. Patch attached. Not sure how to add test coverage for this, but it should be added.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3328924.patch596 bytesheddn

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Active » Needs review
StatusFileSize
new 3328924.patch596 bytes
mindaugasd’s picture

mindaugasd commented

Adding some errors with access checks on D10. Sorry if unrelated, but just in case these mean anything to you. I get these errors in various many places.

1. Warning: Undefined array key "group" in Drupal\group\Entity\Access\GroupRelationshipAccessControlHandler->checkCreateAccess() (line 61 of modules/contrib/group/src/Entity/Access/GroupRelationshipAccessControlHandler.php). 
2. TypeError: Drupal\group\Plugin\Group\RelationHandler\GroupMembershipAccessControl::relationshipCreateAccess(): Argument #1 ($group) must be of type Drupal\group\Entity\GroupInterface, null given, called in web/modules/contrib/group/src/Entity/Access/GroupRelationshipAccessControlHandler.php on line 61 in Drupal\group\Plugin\Group\RelationHandler\GroupMembershipAccessControl->relationshipCreateAccess() (line 90 of modules/contrib/group/src/Plugin/Group/RelationHandler/AccessControlTrait.php).
kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented

Hmm dammit, just combed over all changes manually again to double-check and will tag new release.

Re #3: please open a separate issue.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Needs work

Already committing and releasing fix, but leaving issue open for adding test coverage.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Issue tags: +Needs tests
sweetchuck’s picture

sweetchuck
Primary language Hungarian
Location Budapest
commented

The issue and the error messages mentioned in comment #3 are still exists in
drupal/core: 11.3.2
drupal/group: 3.3.5

sweetchuck’s picture

sweetchuck
Primary language Hungarian
Location Budapest
commented

In case somebody lands here, because of searching for a solution for error messages in comment #3.
The problem is that group and entity_clone modules aren't friends.

drupal/core: 11.3.2
drupal/group: 3.3.5
drupal/entity_clone: 2.1.0-beta1

  1. Go to /admin/config/system/entity-clone/clonable-entities
  2. Uncheck the checkbox for Group relationship
  3. This solved the problem on page: /group/1/content