Problem/Motivation

Seems to not work for issue forks at the moment. Maybe this fixes it?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork welcome_mail-3328214

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

eiriksm created an issue. See original summary.

eiriksm opened merge request !5

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber
Status: Active » Needs review

I will do a review

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented

Hi @eiriksm I revised your composer.json file and I just added some importants points of a composer.json file please revise.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented

I removed the core require part, as this is hard to remember to update alongside the info yml file. Drupal packaging will take care of that.

Otherwise I don't have any strong feelings about any of your changes, so sure 🤓 thank you!

  • eiriksm committed 295e0be0 on 8.x-1.x 
    Issue #3328214 by eiriksm, elber: Add a composer.json for the project
eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.