Problem/Motivation
Per @longwave in #3324560: Replace strpos/substr with str_starts_with() / str_contains() / str_ends_with():
The out of scope change is due to PHPStorm automatically changing
list()to[].We fixed it once across core in #3222769: [November 8, 2021] Replace all list (array destructuring) assignment to the array syntax
Then it was accidentally reverted again in #3181778: [w/c September 17th] Replace t() with $this->t() in all plugins
[ayrton:drupal | Sun 19:26:03] $ grep -rE "\blist\(" * | grep -v "vendor" | grep -v "node_modules"
core/modules/link/src/Plugin/Field/FieldWidget/LinkWidget.php: list($entity_type, $entity_id) = explode('/', substr($uri, 7), 2);Proposed resolution
Fix it in its own patch.
| Comment | File | Size | Author |
|---|---|---|---|
| scope_plz.patch | 811 bytes | xjm |
Comments
Comment #3
xjmComment #4
longwaveConfirmed this is the only instance in core with a slightly different method:
Comment #8
catchCommitted/pushed to 10.1.x, 10.0.x and 9.5.x, thanks!
Comment #9
catch