Problem/Motivation

- Drupal 10 got released, need to upgrade requirements
- Updated core_version_requirement to 9/10
- Changed core/jquery.once dependency to core/once

term_reference_tree.js uses a lot of jQuery so that will need a total rewrite at some stage but that'll be for another issue, these changes will be enough to get the updates going

Issue fork term_reference_tree-3327539

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

j-vee created an issue. See original summary.

j-vee opened merge request !10

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Needs review » Needs work

Thanks @j-vee.
Some work required: see my comments on MR.

j-vee’s picture

j-vee commented

Cheers, I changed the requirement and added a question about passing once in as a parameter.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented

See example in After (removing jQuery dependency) section in this article.

j-vee’s picture

j-vee commented

The example does have it but none of the core JS does, so the doc might be out of date. But I've added it now to this MR. Thanks!

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Needs work » Reviewed & tested by the community

Thank you @j-vee 🥂

Plenty of examples in core: https://git.drupalcode.org/search?search=%22Drupal%2C+once%22&nav_source...

j-vee’s picture

j-vee commented

There's many more cases of once not being included as a parameter whenever it is used in core's JS, hence my confusion of the fact https://git.drupalcode.org/search?group_id=2&nav_source=navbar&project_i...

But still, works with or without. Happy for this to be released. Thanks!

dgwolf’s picture

dgwolf commented

Glad to read you are making this very helpful module D10 compatible, thanks a lot. Any idea when you will be able to release it?

  • VladimirAus committed a1644ea2 on 2.0.x 
    Issue #3327539 by j-vee, VladimirAus: Drupal 10 compatibility
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Assigned: j-vee » Unassigned
Status: Reviewed & tested by the community » Fixed

Committed and ready to use as in branch 2.0.x.

VladimirAus closed merge request !10

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Version: 8.x-1.x-dev » 2.0.x-dev
dgwolf’s picture

dgwolf commented

Wow, this was fast! Thank you very much!
Greetings from Austria to Australia

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented

👋 🇦🇹 🇦🇺

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.