Problem/Motivation

After update to 1.2.1, "edit cookie information" links are rendered on the cookies information page, even if user is not logged in.
Clicking on the links results in "access denied" as expected.

See attached screenshot (site in French)

CommentFileSizeAuthor
#3 PixelSnap 2022-12-14 at 16.42.24.png140.94 KBquimic

Issue fork cookies-3327196

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

quimic created an issue. See original summary.

anybody’s picture

Assigned: Unassigned » grevil
Issue tags: +Needs tests

@quimic thanks for the report! Could you post a screenshot to be sure we're talking about the same?

@Grevil could you please have a look and add a test?

quimic’s picture

Issue summary: View changes
StatusFileSize
new140.94 KB
anybody’s picture

Thank you very much @quimic - we'll fix that, so that only users with the permission to edit the cookie information can see that link.

quimic’s picture

Thank you @anybody!

Grevil made their first commit to this issue’s fork.

anybody’s picture

@Grevil let's remove the link entirely. If easily possible, add a contextual link instead.

grevil’s picture

I tried implementing a contextual link, but can't seem to properly implement it. See #3328025: Add a contextual link to both cookies entities and cookies groups on the cookies documentation page.

So for now I am going to simply remove the link and adjust some form descriptions here and there.

anybody’s picture

Thanks @Grevil: For the form descriptions assume the contextual link to be working. I'll pick that one up.

Ping me for review once you removed the code here.

anybody’s picture

Assigned: grevil » Unassigned
Status: Active » Reviewed & tested by the community

Thanks @Grevil! Merging this incl. the unrelated text fixes!

  • Anybody committed 52881d07 on 1.2.x authored by Grevil
    Issue #3327196 by Grevil, Anybody, quimic: "Edit cookie information"...
anybody’s picture

Status: Reviewed & tested by the community » Fixed

Will be part of 1.2.2! :)

  • Anybody committed b4f3c465 on 2.x authored by Grevil
    Issue #3327196 by Grevil, Anybody, quimic: "Edit cookie information"...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.