Currently the module cannot work with Drupal 10.

CommentFileSizeAuthor
#3 interdiff_3-2.txt770 bytessuresh prabhu parkala
#3 3327104-3.patch1.24 KBsuresh prabhu parkala
#2 3327104.patch476 byteskristiantosney

Issue fork paragraphs_report-3327104

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kristiantosney created an issue. See original summary.

kristiantosney’s picture

kristiantosney commented
StatusFileSize
new 3327104.patch476 bytes
suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Active » Needs review
StatusFileSize
new 3327104-3.patch1.24 KB
new interdiff_3-2.txt770 bytes

Updated the patch. Please review!

snap_x made their first commit to this issue’s fork.

snap_x opened merge request !5

snap_x opened merge request !6

snap_x opened merge request !7

snap_x’s picture

snap_x
Location 🇺🇦 Ukraine, Lutsk
commented

Thanks for the patches.
The patch #3 isn't fully correct, becasue according to the change record https://www.drupal.org/node/2940438 it can be compatible only with Drupal ^9.3 version. There are a bit a mess with branches and tags, so I had to create 3 different MR for 8.x-1.1, 8.x-1.2 and 8.x-1.x. So you can use exactly what you need.

szato’s picture

szato commented
Version: 8.x-1.1 » 8.x-1.x-dev
Status: Needs review » Needs work

@snap_x,

Both MR#6 and MR#7 contain some non-relevant code changes, e.g. removing:
$this->request = $request_stack;

The MR#5 contains correct changes (I'm already using it with Drupal core 10.1.1.), just change the target branch from 8.x-1.1 to 8-x.1-x.

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented
Version: 8.x-1.x-dev » 2.x-dev

Moving this to 2.x for the Drupal 10 version. 2.x-dev is in line with 8.x-1.x which is there version we needed to patch against. All future development will go in the 2.x branch.

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented
Status: Needs work » Fixed

This will be the defacto 2.0 release.

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.