Problem/Motivation

When you use a service like Google Translate it will (try to) translate every text it sees on the site, including filenames.

Translated filenames

Steps to reproduce

  1. Add a service like Google Translate
  2. Upload a filename that contains text
  3. Observe that the filename is translated (you may need to switch to different languages)

Proposed resolution

Add the notranslate class to the file names in the different template files.

Which results in the file not being translated during upload.
Uploading files in a comment

And also not during normal view.
Viewing a node with comments that have attached files which are no longer translated

Remaining tasks

N/a

User interface changes

N/a

API changes

N/a

Data model changes

N/a

CommentFileSizeAuthor
Screenshot 2022-12-08 at 09.24.38.png78.64 KBbramtenhove
Screenshot 2022-12-08 at 09.24.28.png37.54 KBbramtenhove
translatedfilenames.png39.52 KBbramtenhove

Issue fork socialbase-3325956

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bramtenhove created an issue. See original summary.

bramtenhove opened merge request !160

bramtenhove’s picture

bramtenhove CreditAttribution: bramtenhove at Open Social for Open Social commented
Status: Active » Needs review

See Merge Request

  • c609e09 committed on 2.4.x 
    Issue #3325956: Services like Google Translate also translate filenames

  • robertragas committed b530b0f on 2.3.x 
    Issue #3325956: Services like Google Translate also translate filenames
robertragas’s picture

robertragas CreditAttribution: robertragas at Open Social commented
Status: Needs review » Fixed

Reviewed, approved and merged. Will be landing in 2.4.5 and 2.3.6

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.