Problem/Motivation
While investigating another issue I spotted this code in \Drupal\Component\DependencyInjection\Container::reset():
if (!empty($this->scopedServices)) {
throw new LogicException('Resetting the container is not allowed when a scope is active.');
}
Scoped services were deprecated in Symfony 2.8 and removed in Symfony 3: https://symfony.com/blog/new-in-symfony-2-8-deprecating-scopes-and-intro...
We removed most mentions of scoped services in #2712647: Update Symfony components to ~3.2 but this one was missed.
Steps to reproduce
Proposed resolution
Remove these lines.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3325857-2.patch | 669 bytes | longwave |
Comments
Comment #2
longwaveComment #3
andypostbot should be green, nice clean-up
Comment #7
xjmNice find! I confirmed that this is the only remaining reference:
Committed to 10.1.x, and cherry-picked to 10.0.x and 9.5.x. Thanks!
Comment #8
xjm