Use Vanilla JS instead of jQuery as there is initiative in core to remove jQuery

CommentFileSizeAuthor
#6 scrollup-vanilla-js.patch5.31 KBvknikolov
#5 scrollup-vanilla-js.patch5.28 KBvknikolov
#3 scrollup-vanilla-js.patch5.31 KBvknikolov
#2 scrollup-vanilla-js.patch5.52 KBvknikolov

Issue fork scrollup-3325272

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vknikolov created an issue. See original summary.

vknikolov’s picture

vknikolov commented
StatusFileSize
new scrollup-vanilla-js.patch5.52 KB
vknikolov’s picture

vknikolov commented
StatusFileSize
new scrollup-vanilla-js.patch5.31 KB
vknikolov’s picture

vknikolov commented

show label on 2 rows

vknikolov’s picture

vknikolov commented
Title: Rewrite scrollup to Vanila JS » Rewrite scrollup to use Vanila JS
StatusFileSize
new scrollup-vanilla-js.patch5.28 KB

LTR/RTL support

vknikolov’s picture

vknikolov commented
StatusFileSize
new scrollup-vanilla-js.patch5.31 KB

Fix once check

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Version: 3.0.0 » 3.0.x-dev
Assigned: vknikolov » Unassigned
Status: Active » Needs work

Latest patch no longer apply.

VladimirAus opened merge request !7

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Issue summary: View changes
Status: Needs work » Needs review
jannakha’s picture

jannakha commented
Status: Needs review » Needs work

- set default value for scroll_title in case it's empty
- title should not be hardcoded: `title="scroll_title"`
- you can use Template literals, `title=${scroll_title}`
- use semantic HTML, eg <a><span>...</span></a> (not <a><div>...</div></a>

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Needs work » Needs review

Thank you for review! 🧁
Updated.

jannakha’s picture

jannakha commented
Status: Needs review » Reviewed & tested by the community

this MR is good to go.

  • VladimirAus committed 6ff48c92 on 3.0.x 
    Issue #3325272 by VladimirAus, vknikolov, jannakha: Rewrite scrollup to...
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Thank you! Committed! 🥂

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.