Problem/Motivation
Running upgrade_status generates this report for eme:
Entity Migrate Export, 1.0.0-alpha11
Scanned on Tue, 29/11/2022 - 06:34
FILE:
web/modules/contrib/eme/tests/modules/eme_test_module_extension_list/src/ModuleExtensionList.php
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 12 Class
Drupal\eme_test_module_extension_list\ModuleExtensionList
extends @internal class
Drupal\Core\Extension\ModuleExtensionList.
--------------------------------------------------------------------------------
FILE: web/modules/contrib/eme/tests/src/Unit/DiscoveryPluginManagerTest.php
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 45 Call to deprecated method prophesize() of class
PHPUnit\Framework\TestCase:
https://github.com/sebastianbergmann/phpunit/issues/4141
--------------------------------------------------------------------------------
Check manually 46 Call to deprecated method prophesize() of class
PHPUnit\Framework\TestCase:
https://github.com/sebastianbergmann/phpunit/issues/4141
--------------------------------------------------------------------------------
Check manually 47 Call to deprecated method prophesize() of class
PHPUnit\Framework\TestCase:
https://github.com/sebastianbergmann/phpunit/issues/4141
--------------------------------------------------------------------------------
FILE:
web/modules/contrib/eme/tests/src/Unit/Plugin/ReferenceDiscovery/EntityReference
Test.php
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 29 Call to deprecated method prophesize() of class
PHPUnit\Framework\TestCase:
https://github.com/sebastianbergmann/phpunit/issues/4141
--------------------------------------------------------------------------------
Check manually 30 Call to deprecated method prophesize() of class
PHPUnit\Framework\TestCase:
https://github.com/sebastianbergmann/phpunit/issues/4141
--------------------------------------------------------------------------------
Check manually 31 Call to deprecated method prophesize() of class
PHPUnit\Framework\TestCase:
https://github.com/sebastianbergmann/phpunit/issues/4141
--------------------------------------------------------------------------------
Check manually 32 Call to deprecated method prophesize() of class
PHPUnit\Framework\TestCase:
https://github.com/sebastianbergmann/phpunit/issues/4141
--------------------------------------------------------------------------------
Check manually 33 Call to deprecated method prophesize() of class
PHPUnit\Framework\TestCase:
https://github.com/sebastianbergmann/phpunit/issues/4141
--------------------------------------------------------------------------------
Check manually 47 Call to deprecated method prophesize() of class
PHPUnit\Framework\TestCase:
https://github.com/sebastianbergmann/phpunit/issues/4141
--------------------------------------------------------------------------------
FILE: web/modules/contrib/eme/eme.libraries.yml
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 0 The 'export-id' library is depending on a deprecated
library. The core/jquery.once asset library is deprecated in
Drupal 9.3.0 and will be removed in Drupal 10.0.0. Use the
core/once library instead. See
https://www.drupal.org/node/3158256
--------------------------------------------------------------------------------
Only the last reported issue seems to be relevant here: there may – or may not – be something more to do in order to support D10.
Steps to reproduce
composer show drupal/core | grep versions
# Put the version output by the previous command into the following, in place of "9.4.8":
composer require --dev drupal/core-dev:9.4.8 --update-with-all-dependencies
composer require drupal/upgrade_status
vendor/bin/drush en upgrade_status
vendor/bin/drush us-a --all >& ../upgrade-status.txt
Comments
Comment #2
richard.walker.ardc commentedExplanations and examples showing how to use
core/onceinstead ofjquery.oncein the behavior definition:Comment #3
huzookaWell, since issue title already complains about jquery/once only, and because Drupal core 10.1.x also uses prophesize a lot, let's officially reduce the scope to the deprecated (and in 10.x, removed) library dependency.
Here is a fix, I hope it will make tests pass.
Comment #4
huzookaComment #7
huzookaCommitted to 2.x and cherry-picked to 1.0.x.
Will be released in 1.0.0-alpha13
Comment #8
huzookaComment #9
richard.walker.ardc commentedYes, that's exactly what I meant by:
Thank you for fixing.
Comment #10
huzooka🤦 ...and I forgot to release this! Now it's done: https://www.drupal.org/project/eme/releases/1.0.0-alpha13