Problem/Motivation

Based on #3323977: Drupal 10 only: Drush support it seems we should make a semantic versioned 2.x that only supports Drupal 10.

I propose keeping support for the 8.x-1.x branch for as long as Drupal 9 is supported and as long as folks are interested in maintaining it.

We should document clearly on the project page when to use which branch.

Remaining tasks

* Adjust info file to specify 8.x is Drupal 9 only and 2.x is Drupal 10 only
* Proposed documentation for the project pge
* Agreement among maintainers on this proposal

Issue fork stage_file_proxy-3323978

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

greggles created an issue. See original summary.

smustgrave’s picture

smustgrave commented

Sounds like we will have to revert the D10 work from the 8.x-1.x branch also.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Does the work so far make it D10 only or does it work ok on D9?

smustgrave’s picture

smustgrave commented

According to #3323977: Drupal 10 only: Drush support it's saying 10 isn't working and the change can't be made in 9. (haven't checked)

But if that's the case we should revert back 8.x-1.x to D9 only and make 2.0.x D10 only.

Thoughts?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Can you list out the things that need to be reverted?

smustgrave’s picture

smustgrave commented

Reviewing https://git.drupalcode.org/project/stage_file_proxy/-/commit/c939229

We may be able to just remove the change in the .info

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Issue summary: View changes

OK, got it. Thanks!

Adjusting the issue summary to match that situation.

Does this proposal make sense to you?

smustgrave’s picture

smustgrave commented

Yup will try and work on this tomororw.

smustgrave opened merge request !24

smustgrave’s picture

smustgrave commented
Status: Active » Needs review

Take a look at the MR

Should revert 8.x-1.x. to D9 only

Pushed https://git.drupalcode.org/project/stage_file_proxy/-/tree/2.0.x up too which is for D10.

Once this RTBC will merge in https://www.drupal.org/project/stage_file_proxy/issues/3323977

Do a 2.0.0 release and 8.x-1.5 release
and update project page.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Reviewed & tested by the community

The test fail is on Drupal 10 which...makes sense :)

I adjusted the config so the 8.x-1.x branch no longer has a Drupal 10 test run for it. We should add that test to the 2.0.x branch when a release exists.

MR looks good to me. Thanks!

  • smustgrave committed d8aaf6a on 8.x-1.x 
    Issue #3323978: Create 2.x branch to support only Drupal 10
smustgrave’s picture

smustgrave commented
Status: Reviewed & tested by the community » Fixed
smustgrave’s picture

smustgrave commented

All done!

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

This prevents folks from upgrading to D10 without uninstalling stage_file_proxy, since there is no bridge from 9 -> 10. 1.5 is strictly D9 and 2.0.0 is strictly D10.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Followup for #15 is in #3325366: Add support for D9 on 2.0.x branch.

nomisgnos’s picture

nomisgnos commented

For stage_file_proxy.info.yml Doesn't this have to be updated to core_version_requirement: ^10 ?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.