Problem/Motivation

After cache clear most pages produce error notice:

Notice: Undefined variable: output in shorthand_help() (line 33 of modules/contrib/shorthand/shorthand.module).

Drupal 9.4.8
php 7.4.13
shorthand 4.0.2

CommentFileSizeAuthor
#2 3323618-undefined-variable-output.patch443 bytesroman_pro

Issue fork shorthand-3323618

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

roman_pro created an issue. See original summary.

roman_pro’s picture

roman_pro commented
StatusFileSize
new 3323618-undefined-variable-output.patch443 bytes

Patch attached.

roman_pro’s picture

roman_pro commented
Status: Active » Patch (to be ported)
jannakha’s picture

jannakha commented

why the status is not "Needs review"?

roman_pro’s picture

roman_pro commented
Status: Patch (to be ported) » Needs review

updated status.

jannakha’s picture

jannakha commented
Status: Needs review » Reviewed & tested by the community

Fixed, pls release! 👍

darkdim made their first commit to this issue’s fork.

darkdim opened merge request !16

VladimirAus made their first commit to this issue’s fork.

  • VladimirAus committed c9366308 on 4.0.x authored by darkdim 
    Issue #3323618 by roman_pro: Notice: Undefined variable: output in...
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Version: 4.0.2 » 4.0.x-dev
Assigned: roman_pro » Unassigned
Status: Reviewed & tested by the community » Fixed

Merged!
Thanks everyone! 🍻

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.