Problem/Motivation

If a form does not load properly, for example if the Form Assembly url is malformed or service is temporarily interrupted, then the page throws an \UnexpectedValueException and WSOD.

Steps to reproduce

Sync forms, add one to the page however you normally would and then delete the form on the Form Assembly side, OR
manually edit the ApiMarkup class to force a malformed url during the httpClient->get call.

Proposed resolution

Gracefully fail and show an error message that the form cannot be loaded.

Issue fork formassembly-3323199

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nsciacca created an issue. See original summary.

nsciacca opened merge request !5

nsciacca’s picture

nsciacca
She/Her/Hers
Primary language English
commented
Status: Active » Needs review

Patch for testing: https://git.drupalcode.org/project/formassembly/-/merge_requests/5.patch

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
Version: 8.x-1.x-dev » 2.x-dev

  • 15b7ce1 committed on 2.x 
    Issue #3323199 by nsciacca: Form loading error 404 WSOD in D9
fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
Status: Needs review » Fixed
fathershawn’s picture

fathershawn
Primary language English
Location New York
commented

Thanks for the recent fixes @nsciacca. Try/Catch was exactly how that code section should have been structured :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.