Problem/Motivation

Hi, thanks for this module!

I noticed that the module works fine if the widthcontrol setting is on, but that it fails if you turn it off. The editor shows a message that the block has an error and cannot be previewed, and the console reports:

react-dom.min.js?v=16.8.4:formatted:4299 TypeError: Cannot read properties of undefined (reading 'includes')
    at DrupalContentEmbed.render (drupal-content-embed.js?rlqrvz:314:26)

Steps to reproduce

Turn off setting for widthcontrol on a content type / view mode

Proposed resolution

We need an additional check, PR coming.

CommentFileSizeAuthor
#4 3323089-disabling-widthcontrol.patch2.42 KBvegardjo

Issue fork gutenberg_content_embed-3323089

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vegardjo created an issue. See original summary.

vegardjo opened merge request !4

vegardjo’s picture

vegardjo commented
Status: Active » Needs review
vegardjo’s picture

vegardjo commented
StatusFileSize
new 3323089-disabling-widthcontrol.patch2.42 KB

Added a patch file as well

  • jidrone committed cf678773 on 1.0.x 
    Issue #3323089 by vegardjo,, jidrone: Disabling widthControl gives error
jidrone’s picture

jidrone commented

Merged, thanks for reporting and helping with the fix.

jidrone’s picture

jidrone commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.