Drupal Coding Standard. [#3321367]

Problem/Motivation

FILE: ...modules/contrib/stage_file_proxy/tests/src/Functional/SettingsFormTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 15 | ERROR | Missing member variable doc comment
--------------------------------------------------------------------------------


FILE: ...s/contrib/stage_file_proxy/src/Controller/ImageStyleDownloadController.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 23 | ERROR | Missing member variable doc comment
--------------------------------------------------------------------------------


FILE: ...b/modules/contrib/stage_file_proxy/src/EventSubscriber/ProxySubscriber.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 155 | WARNING | Unused variable $is_webp.
--------------------------------------------------------------------------------


FILE: ...stage_file_proxy/src/EventSubscriber/ImageDownloadControllerSubscriber.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------------
 23 | ERROR | If there is no return value for a function, there must not be a
    |       | @return tag.
 23 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------------


FILE: ...s/contrib/stage_file_proxy/src/EventDispatcher/AlterExcludedPathsEvent.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 11 | WARNING | The class short comment should describe what the class does and
    |         | not simply repeat the class name
--------------------------------------------------------------------------------


FILE: ...rupal_9.4/drupal/web/modules/contrib/stage_file_proxy/src/FetchManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 101 | ERROR | The array declaration extends to column 111 (the limit is 80).
     |       | The array content should be split up over multiple lines
--------------------------------------------------------------------------------

Time: 1.6 secs; Memory: 12MB

Comment	File	Size	Author
#6	patch_reviewd.png	183.25 KB	kuntal_d
#5	Drupal-Coding-Standard-3321367-5.patch	4.29 KB	dharti patel
#2	Drupal-Coding-Standard-3321367-2.patch	3.26 KB	rohit rana

Issue fork stage_file_proxy-3321367

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3321367-drupal-coding-standard changes, plain diff MR !21
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

15 November 2022 at 06:57

Rohit Rana created an issue. See original summary.

Comment #2

rohit rana commented 15 November 2022 at 07:00

Status	File	Size
new	Drupal-Coding-Standard-3321367-2.patch	3.26 KB

Comment #3

rohit rana commented 15 November 2022 at 07:12

Assigned:	rohit rana	» Unassigned
Status:	Active	» Needs review

Please Review.

Comment #4

dharti patel commented 15 November 2022 at 11:59

Assigned:

Unassigned

» dharti patel

Hello,

I'll review this patch.

Thanks!

Comment #5

dharti patel commented 15 November 2022 at 12:33

Assigned:

dharti patel

» Unassigned

Status	File	Size
new	Drupal-Coding-Standard-3321367-5.patch	4.29 KB

Hello,

Review the #2 patch and after applying the patch face the below issues.

FILE: /home/drupal/d9-open/stage_file_proxy/INSTALL.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
 30 | WARNING | Line exceeds 80 characters; contains 92 characters
 43 | WARNING | Line exceeds 80 characters; contains 92 characters
 47 | WARNING | Line exceeds 80 characters; contains 90 characters
----------------------------------------------------------------------

Resolved the above issue and create a new patch for the same.
Kindly review this patch.

Thanks!