Problem/Motivation

Noticed while reading the code for something else that https://git.drupalcode.org/project/group_permissions/-/blob/2.0.x/src/Co... calls GroupPermissionsManagerInterface::getGroupRoles() which I think I'm correct in saying has been removed. The form replaced it with a method https://git.drupalcode.org/project/group_permissions/-/blob/2.0.x/src/Fo...

Sorry if it's already on the todo. But thought it best to log when I spotted it. I've not actually tried to view a revision...

Proposed resolution

Repeat the method code, it's trivial? Move it somewhere?

Issue fork group_permissions-3321278

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ekes created an issue. See original summary.

LOBsTerr made their first commit to this issue’s fork.

LOBsTerr opened merge request !14

lobsterr’s picture

lobsterr commented
Status: Active » Fixed

@ekes A nice catch, I completely forgot to check revisions pages.

  • LOBsTerr committed 8869983 on 2.0.x 
    Issue #3321278 by LOBsTerr: View revision call to removed method

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

leomontenegro6’s picture

leomontenegro6 commented

So, the "getGroupRoles" method present in 1.0.0 was deleted in 2.0.0, and replaced by the "getNonAdminRoles" method, right?

I was taking a look at both methods, to check their differences. Although both are listing group roles, are they indeed equal? The latter seems to ignore admin roles, with the former seeming to get all roles without distinction. Will it give the same results regardless, or should we take that into consideration when updating 1.0.0 to 2.0.0 as well?