We could be using README.md instead of README.txt to make use of the nicer rendering via markdown.

Now that we've moved to GitLab, we should probably use Markdown instead of plain .txt files for our documentation

CommentFileSizeAuthor
#14 Result1.png292.03 KBparaderojether
#14 Result.png249.83 KBparaderojether
#7 3338040-8.patch3.07 KBrohitsharma401
#6 Result.png48.36 KBparaderojether
#4 3321135.patch1.5 KBrohitsharma401

Issue fork theme_switcher-3321135

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nitapawar created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: nitapawar » Unassigned
Status: Needs review » Needs work

@nitapawar you didn't provide a MR yet!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 8.x-1.2 » 2.x-dev
rohitsharma401’s picture

rohitsharma401 commented
Assigned: Unassigned » rohitsharma401
Status: Needs work » Needs review
StatusFileSize
new 3321135.patch1.5 KB

Patch for Changing README.txt to README.md as per markdown syntax.

rohitsharma401’s picture

rohitsharma401 commented
Assigned: rohitsharma401 » Unassigned
paraderojether’s picture

paraderojether commented
Status: Needs review » Needs work
StatusFileSize
new Result.png48.36 KB

Hi @ rohitsharma401

I reviewed patch #4 and it fails to apply for me, Theme Switcher Rules version 2.x-dev, Drupal Core version 9.4.7, PHP version 8.1.8. Another concern, please also follow the new template: https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

Please check.
Thank You.

rohitsharma401’s picture

rohitsharma401 commented
Assigned: Unassigned » rohitsharma401
Status: Needs work » Needs review
StatusFileSize
new 3338040-8.patch3.07 KB

Here is the patch with Proper markdown and Sentence-case with Drupal Guidelines .

rohitsharma401’s picture

rohitsharma401 commented
Assigned: rohitsharma401 » Unassigned

nayana_mvr made their first commit to this issue’s fork.

nayana_mvr opened merge request !5

nayana_mvr’s picture

nayana_mvr commented

Verified the patch #7. There were some format issues. Corrected them and created an MR for this ticket with all the changes. Please review.
Thanks.

hardikpandya’s picture

hardikpandya commented
Assigned: Unassigned » hardikpandya
Status: Needs review » Needs work

The MR is currently not mergeable and would need a rebase.

hardikpandya’s picture

hardikpandya commented
Assigned: hardikpandya » Unassigned
Status: Needs work » Needs review

Rebased and added hyperlinks to the table of content items.

paraderojether’s picture

paraderojether commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Result.png249.83 KB
new Result1.png292.03 KB

Hi @ nayana_mvr and hardikpandya

I reviewed the MR and your changes, and this looks good to me.

Moving this to RTBC.
Thank You.

thakurnishant_06 made their first commit to this issue’s fork.

thakurnishant_06’s picture

thakurnishant_06 commented
Status: Reviewed & tested by the community » Needs work
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

@#16: What work is needed?