Problem/Motivation

The option to allow Icon position to be set is ignored when adding an icon.

Steps to reproduce

- Disable the option to set an Icon position
- Add an icon and see the option is there regardless

Proposed resolution

Re-add the condition in the code for checking the configuration-option

User interface changes

none

API changes

none

Data model changes

none

Issue fork micon-3321058

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

SpadXIII created an issue. See original summary.

SpadXIII opened merge request !23

spadxiii’s picture

spadxiii commented
Status: Active » Needs review

Added the condition-check in a new mr

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 2.1.0-beta2 » 2.x-dev
Assigned: Unassigned » grevil
Status: Needs review » Reviewed & tested by the community

Thanks @SpadXIII you're right. RTBC. If you agree @Grevil, please merge!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
grevil’s picture

grevil commented
Component: Code » micon_link submodule
Status: Reviewed & tested by the community » Postponed

For me, generally the "micon_link" module doesn't work properly, see #3331508: Micon Link module doesn't display addable icons. So we should fix the module first, before adding this functionality. Might only be the case for Drupal 10, I am unsure about that.

POSTPONED on #3331508: Micon Link module doesn't display addable icons.

thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented
Status: Postponed » Active

#3331508: Micon Link module doesn't display addable icons closed as outdated, so we can proceed here!

grevil’s picture

grevil commented
Title: Allow Icon position-setting is ignored » Allow Icon position-setting and adjust formatter view and Widget fallback icon logic
Assigned: grevil » Unassigned
grevil’s picture

grevil commented
Status: Active » Needs review

There were a couple more issues, so I fixed them accordingly. Please review!

grevil’s picture

grevil commented
Title: Allow Icon position-setting and adjust formatter view and Widget fallback icon logic » Allow Icon position setting is ignored and adjust formatter view and Widget fallback icon logic
thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented
Status: Needs review » Reviewed & tested by the community

  • Grevil committed 81811be7 on 2.x authored by SpadXIII 
    Issue #3321058 by Grevil, SpadXIII, Anybody: Allow Icon position setting...
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.