Problem/Motivation
During our QA process of a web built with da_vinci theme, we noticed the menú and some javascript-dependent components we added were not working properly when you visualize the site using an iOs device but they looked pixel-perfect on the rest of the devices. Reviewing the code we noticed there is a missing parenthesis in the matchMedia function parameter.
And here is the thing, according to the documentation if there is a missing parenthesis on any device the browser auto-completes it, in all devices except for iOs.
Steps to reproduce
Install the theme, and visualize the site by using android and ios at the same time, you will notice the menu will have different aspects and behavior.
Proposed resolution
Add the missing parenthesis at main.js line 34
Remaining tasks
Review and approval.
| Comment | File | Size | Author |
|---|---|---|---|
| missing_parenthesis_at_matchMedia_param.patch | 677 bytes | ldcruz |
Comments
Comment #4
nesta_ commentedComment #5
nesta_ commented