Problem/Motivation

The renderEmbedCode function returns a build using the html_tag type. It would be more flexible to use the video_embed_iframe type like the other providers in video_embed_field do.

Use case: I needed to alter the iframe code a bit to integrate it with our cookie consent script. Having a proper template makes this a lot easier.

CommentFileSizeAuthor
#2 video_embed_facebook-3318857-2.patch1.29 KBrobbevb

Comments

robbevb created an issue. See original summary.

robbevb’s picture

robbevb commented
StatusFileSize
new video_embed_facebook-3318857-2.patch1.29 KB

Use attached patch to switch to the video_embed_iframe render type.

robbevb’s picture

robbevb commented
Issue summary: View changes
robbevb’s picture

robbevb commented
Status: Active » Needs review
stijnstroobants’s picture

stijnstroobants
Primary language Dutch
Location Leuven
commented
Status: Needs review » Reviewed & tested by the community

Good improvement! Tested and seems to work!

  • robbevb authored de4dffe8 on 8.x-1.x 
    Issue #3318857 by robbevb: Use video_embed_iframe template
stijnstroobants’s picture

stijnstroobants
Primary language Dutch
Location Leuven
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.