Problem/Motivation

Module Info Entity accepts non existing module machine names.

Steps to reproduce

Try to add no existing modules in module info add page. It should throwing error for non existing modules but it is saving data.

Proposed resolution

check for module existence before saving , one way it can be handled is by checking response code of http client.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 Screenshot from 2023-06-20 20-34-23.png118.23 KBagunjan085
#6 Screenshot from 2023-06-20 20-37-39.png98.73 KBagunjan085
#6 Screenshot from 2023-06-20 20-42-45.png127.74 KBagunjan085

Issue fork modules_info-3318703

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Bhanu951 created an issue. See original summary.

andrew answer’s picture

andrew answer commented

Hi, thank you for checking. Can you provide the good-qualified patch? This will be a real contribution (compared to https://www.drupal.org/project/modules_info/issues/3318676#comment-14794039)

nidhi27 made their first commit to this issue’s fork.

nidhi27 opened merge request !5

nidhi27’s picture

nidhi27
She/Her
commented
Status: Active » Needs review

For this issue I have added the constraint to machine name field which will check before the saving of the entity.

Created #MR5 for the same.

agunjan085’s picture

agunjan085 commented
StatusFileSize
new Screenshot from 2023-06-20 20-42-45.png127.74 KB
new Screenshot from 2023-06-20 20-37-39.png98.73 KB
new Screenshot from 2023-06-20 20-34-23.png118.23 KB

I have verified MR https://git.drupalcode.org/project/modules_info/-/merge_requests/5 on Drupal9 as on Drupal10 i was facing https://www.drupal.org/project/modules_info/issues/3366016

I was able to add dummy machine names before.
After taking the MR code on save it is not letting us save dummy module machine name.

agunjan085’s picture

agunjan085 commented
Status: Needs review » Reviewed & tested by the community

Andrew Answer closed merge request !5

andrew answer’s picture

andrew answer commented
Status: Reviewed & tested by the community » Fixed
nidhi27’s picture

nidhi27
She/Her
commented

Hi @Andrew,

Kindly give the credit as MR is merged to the module.

nidhi27’s picture

nidhi27
She/Her
commented
andrew answer’s picture

andrew answer commented
agunjan085’s picture

agunjan085 commented

Hi @Andrew,

Kindly give the credit as the fix is working fine as tested.

andrew answer’s picture

andrew answer commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.