Problem/Motivation

When returning from Mollie, the last payment is loaded without checking if that payment belongs to a mollie gateway plugin.

Proposed resolution

Find and use the last mollie payment.

CommentFileSizeAuthor
#6 3318548-4.patch1.01 KBjmeijer
#5 3318548-3.patch1.22 KBjmeijer
#2 3318548-2.patch1.35 KBcasey

Comments

casey created an issue. See original summary.

casey’s picture

casey commented
Status: Active » Needs review
StatusFileSize
new 3318548-2.patch1.35 KB

  • ndf committed 60a9b1e on 8.x-1.x 
    #3318548 by casey: Return controller loads non-mollie payments
ndf’s picture

ndf commented
Status: Needs review » Fixed

Thanks casey!

jmeijer’s picture

jmeijer commented
StatusFileSize
new 3318548-3.patch1.22 KB

We should check if the Gateway is an instance of Mollie Gateway instead of checking if it's specifically the Mollie Gateway. This allows Gateways that extend the Mollie Gateway to be handled by the ReturnController as well.

jmeijer’s picture

jmeijer commented
StatusFileSize
new 3318548-4.patch1.01 KB

Sorry, made a mistake in the last patch

ndf’s picture

ndf commented

@jmeijer Can you create a new ticket with the bug-report and link it to this one? Then we can review it in that issue.
NB The patches are failing the test-suite, the tests must be green otherwise we cannot merge the fix.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.