Problem/Motivation

This block of code was flagged by my IDE in entity_share_websub_hub_views_data()

 $data[$table]['table']['join'] = [
    'node_field_data' => [
      'left_table' => 'node',
      'left_field' => 'uuid',
      'field' => 'entity_id',
      'extra' => [
        [
          'field' => 'entity_type',
          'value' => 'node',
        ],
      ],
    ],
  ];
  $data[$table]['table']['join'] = [
    'users_field_data' => [
      'left_table' => 'entity_share_websub_hub_subscription',
      'left_field' => 'uid',
      'field' => 'uid',
    ],
  ];

The second statement immediately overrides the first. Should this be

 $data[$table]['table']['join'] = [
    'node_field_data' => [
      'left_table' => 'node',
      'left_field' => 'uuid',
      'field' => 'entity_id',
      'extra' => [
        [
          'field' => 'entity_type',
          'value' => 'node',
        ],
      ],
    ],
    'users_field_data' => [
      'left_table' => 'entity_share_websub_hub_subscription',
      'left_field' => 'uid',
      'field' => 'uid',
    ],
  ];

Comments

FatherShawn created an issue. See original summary.

fathershawn’s picture

Issue summary: View changes
fathershawn’s picture

Version: 1.0.x-dev » 1.1.x-dev

fathershawn’s picture

Assigned: Unassigned » perelesnyk
Status: Needs review » Fixed

@perelesnyk if we needed the overwritten join for something, please re-open and fix.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.