Problem/Motivation

Remove the "dropdown_type" as it can be set via the css selectors.

Steps to reproduce

Proposed resolution

Remove the "dropdown_type" and let the user use the css selectors instead.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork choices-3317975

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grevil created an issue. See original summary.

Grevil opened merge request !12

grevil’s picture

grevil commented
Status: Active » Needs review

Done, please Review!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Remove the "dropdown_type" as it can be set via the css selectors. » Remove the "dropdown_type" as it can be set via the css selectors any may conflict
Assigned: Unassigned » grevil
Category: Task » Bug report
Status: Needs review » Needs work

Totally agree, because of the possible conflict of these options, which is bad UX.

Anyway, 2 tests fail here, please fix them first @Grevil.

I'm considering the possible conflict as bug.

grevil’s picture

grevil commented
Status: Needs work » Needs review

Forgot to remove "dropdown_type" inside the Tests and on settings Form submit, please review once again!

grevil’s picture

grevil commented

Rebased.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: grevil » Unassigned
Status: Needs review » Reviewed & tested by the community

All passed :) Great!

  • Anybody committed 08bac37 on 2.x authored by Grevil 
    Issue #3317975 by Grevil: Remove the "dropdown_type" as it can be set...
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented

It is better to add a empty update choices_update_8001 again. because a choices_update_8001 will not run on sites which are already on schema version 8001.

And in a perfect drupal-world a update hook choices_update_8002 would remove dropdown_type again.

grevil’s picture

grevil commented

@tobiasb, you are totally right! We decided against it, as the versions released pretty close to each other, and we thought not many people would update it right away. Unfortunately, 13 people use 2.0.4, which introduced the "dropdown_type" config. So we definitely need the update hook, for those few.

Thanks for the concern!

grevil’s picture

grevil commented

@tobiasb, fixed in #3318640: Missing update hook for removing "dropdown_type" config

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.