Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
The release 4.1.15 that removed raw HTML from the twigs (https://git.drupalcode.org/project/modal_page/-/commit/5060a698ec802075c...) ended up breaking the module's approach for the default close button.
Steps to reproduce
On 4.1.15 or above, create a new modal with the default close option - empty or 'x'.
Observe the modal close button will render as × instead of the HTML entity ×
Proposed resolution
Send a new variable for the twig so we can print × directly when there is a default close button. This validation happens on the ModalPageService.
Remaining tasks
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | twig-changes-3317387-5.patch | 887 bytes | luiscarvalho |
Comments
Comment #2
luiscarvalho commentedComment #3
renatog commentedHumm good catch @luiscarvalho
Yeah, we need to take a look on this
P.S. Any patches or MR are welcome
Comment #4
renatog commentedComment #5
luiscarvalho commentedSending a patch for a quick fix. This can definitely be improved.
Comment #6
luiscarvalho commentedComment #7
renatog commented@luiscarvalho looks perfectly acceptable IMHO
Why do you think it can be improved?
Comment #8
renatog commentedTalked directly with Luis and in the future it can be on PHP side, but for now it's ok and can helps other users, so moving to RTBC
Comment #10
renatog commentedMoved to the dev branch
Thank you so much for your contribution, Luis
Comment #11
renatog commentednew release available with this: https://www.drupal.org/project/modal_page/releases/4.1.17