Problem/Motivation

The module is not compatible with Gruop 3.x that is the recommended version for starting new projects with.

Details: https://www.drupal.org/node/3222290

Proposed resolution

Change GroupContentEnablers to GroupRelationType plugins

CommentFileSizeAuthor
#2 3316529-2.patch3.13 KBblazey

Issue fork group_term-3316529

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3.0.x Comparecompare
  • 4.0.x Comparecompare
  • 2.x Comparecompare
  • 3316529-group-3.x-compatibility Comparechanges, plain diff MR !3

Comments

blazey created an issue. See original summary.

blazey’s picture

Status: Active » Needs review
StatusFileSize
new3.13 KB
ekes’s picture

Patch wasn't quite working, at least not now with 3.x is at beta. I've moved it along:

Sadly forking is a bit broken at the moment. So branch is in https://git.drupalcode.org/sandbox/ekes-3319987

ekes’s picture

Fork now also available. Should I make a Merge Request - even though it's not a MR as it should become a new branch / release?
Diff https://git.drupalcode.org/issue/group_term-3316529/-/compare/2.x...3316...

stephen-cox’s picture

There's a schema issue with the group_term view in the issue fork. I don't seem to be able to push changes to this. The fix is very simple:

diff --git a/config/optional/views.view.group_terms.yml b/config/optional/views.view.group_terms.yml
index ba01f99..426951b 100644
--- a/config/optional/views.view.group_terms.yml
+++ b/config/optional/views.view.group_terms.yml
@@ -533,7 +533,7 @@ display:
           group_type: group
           admin_label: 'Group relationship Taxonomy term'
           required: true
-          group_relationship_plugins:
+          group_relation_plugins:
             'group_term:gtdx_vocab': '0'
             'group_term:store_tags': '0'
             'group_term:tags': '0'

That said, this view doesn't show any group terms even with the schema fix, so there are other issues with it.

ekes’s picture

finn lewis’s picture

Hi @Berdir and @mbovan

Could we get a 3.x branch to host the work that @ekes has done on this?

We're using it on the LocalGov Drupal distribution along with Group 3.x

Many thanks,

Finn

lobsterr’s picture

Assigned: blazey » lobsterr

Hi, @blazey, if you don't mind I will take over this ticket from you. I have created a branch for group 2.0 first, then we will migrate it to Group 3.0

lobsterr’s picture

I just released a version from group 2.0, I will start to work on the version for Group 3.0, It should be super quick.

lobsterr’s picture

Version: 2.0.0-alpha1 » 4.0.x-dev

  • b193bb9 committed on 4.0.x
    Issue #3316529 by ekes, LOBsTerr, blazey: Group 3.x compatibility
    
lobsterr’s picture

Status: Needs review » Fixed

Thank you all for contribution a new release to be taged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.