Problem/Motivation

If you run phpcs with the "Drupal" rules provided by coder, there is an endless loop in includes/base.inc due to missing @endcode

In addition, drupal/coder requires @endcode to be on a different line, although arguably this latter issue is a bug in drupal/coder

Steps to reproduce

Can be reproduced in drupalci https://dispatcher.drupalci.org/job/drupal_d7/229934/console or manually via phpcs -v (with a phpcs.xml file that enables the "Drupal" rule).

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 views-n3315509-3.patch2.31 KBDamienMcKenna
#3 views-n3315509-3.interdiff.txt1.86 KBDamienMcKenna
#2 3315509-endcode-newline.patch1.72 KBmfb
#2 3315509.patch413 bytesmfb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mfb created an issue. See original summary.

mfb’s picture

mfb
they or he
CreditAttribution: mfb commented
Status: Active » Needs review
FileSize
3315509.patch413 bytes
3315509-endcode-newline.patch1.72 KB
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #3311884: Plan for Views 7.x-3.28
FileSize
views-n3315509-3.interdiff.txt1.86 KB
views-n3315509-3.patch2.31 KB

Thanks for putting this together.

This version fixes a few other occurrences of @code / @endcode.

mfb’s picture

mfb
they or he
CreditAttribution: mfb commented
Status: Needs review » Reviewed & tested by the community

LGTM - I ran phpcs to verify it completes

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Reviewed & tested by the community » Fixed

Thanks for bringing this up and for the patch. Committed.

  • DamienMcKenna committed ade4304 on 7.x-3.x 
    Issue #3315509 by mfb, DamienMcKenna: phpcs endless loop with "Drupal"...
drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented

(Updating to resolve Drupal.org issue indexing issue, please disregard.)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.