Hi,

I have a crash on 2.x with PHP8.

Problem/Motivation

TypeError: str_replace(): Argument #2 ($replace) must be of type array|string, int given in str_replace() (line 708 of (...)/modules/contrib/entity_share/modules/entity_share_client/src/Service/JsonapiHelper.php)

Steps to reproduce

Go to the "Pull entities" page, select a remote server then select a channel.

Proposed resolution

Force the $remote_entity_id value to string.

Patch comming right up.

Seb

CommentFileSizeAuthor
#2 entity_share-php8_stricttype-3315305-2.patch912 bytesseb_r

Comments

Seb_R created an issue. See original summary.

seb_r’s picture

seb_r commented
StatusFileSize
new entity_share-php8_stricttype-3315305-2.patch912 bytes
seb_r’s picture

seb_r commented
Status: Active » Needs review
erikaagp’s picture

erikaagp commented
Status: Needs review » Reviewed & tested by the community

It seems good to me.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: seb_r » grimreaper

  • Grimreaper committed 6150ec49 on 8.x-2.x authored by Seb_R 
    Issue #3315305 by Seb_R: PHP 8 /  str_replace(): Argument #2 ($replace)...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Version: 8.x-2.0-alpha12 » 8.x-2.x-dev
Assigned: grimreaper » Unassigned
Status: Reviewed & tested by the community » Fixed

Hi,

This is now merged.

I will create a last release for 8.x-2.x and then mark it as unsupported.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.