Problem/Motivation
phpspec/prophecy does not yet support PHP 8.2.
Steps to reproduce
Proposed resolution
upgrade to https://github.com/phpspec/prophecy/releases/tag/v1.16.0
Work with the phpspec/prophecy maitainers to make PHP 8.2 compatibility happen and update Drupal to the new version.
See https://github.com/phpspec/prophecy/labels/PHP8.2 and https://github.com/phpspec/prophecy/pull/571 and https://github.com/phpspec/prophecy/pull/565
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 3314632-11-10.1.patch | 2.52 KB | andypost |
| #11 | 3314632-11-10.0.patch | 2.52 KB | andypost |
Issue fork drupal-3314632
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
catchComment #4
taran2lComment #5
andypostraised to critical as it blocks contrib testing (CI unable to install core on 8.2)
Comment #6
effulgentsia commentedWhy is CI able to install core on PHP 8.2 when testing core, but not able to install core on PHP 8.2 when testing contrib? Is it because when testing contrib, core's root composer.json (which sets config.platform.php) isn't used?
Comment #7
taran2l@effulgentsia, had the same thoughts, there was a discussion in this thread: https://drupal.slack.com/archives/C51GNJG91/p1666257742630159
Comment #8
hestenetUntil this is resolved, we've added a php 8.2 --ignore-platform-reqs version of the container that people can test against:
#3318421: Add a php8.2_mysql8_ignore environment so that contrib can run tests on PHP 8.2 despite phpspec/prophecy
Should be available in the 'add test' dialogue now.
EDIT: Unfortunately this environment is not yet working - will revisit.
Comment #9
catchDo we need to switch to a github fork until there's release with the fix in? Or do we just not support 8.2 testing for contrib until it's done and hope we can update in a patch release before too long?
Comment #10
andypostFork sounds like good workaround as the issue only in constraint and not yet implemented "union types" https://github.com/phpspec/prophecy/pull/565
I'm sure core can be released without support of https://wiki.php.net/rfc/dnf_types as requiring 8.1
Comment #11
andypostre-title as support added https://github.com/phpspec/prophecy/releases/tag/v1.16.0
there's 2 issues left to support new features but they are optional as this issue a blocker for contrib
Comment #12
andypostComment #13
mondrakeProvided testbot comes back green, this seems OK to me.
Comment #15
catchThat's good timing.
Committed/pushed to 10.1.x and 10.0.x respectively, thanks!
Comment #17
andypostThank you! contrib now can run tests!
Comment #18
berdirConfirmed that this works now, token is now passing tests on PHP 8.2: https://www.drupal.org/pift-ci-job/2533591.
Comment #19
liam morlandCan this be backported to Drupal 9.5?
Comment #20
andypostRe #19 I don;t think so as 9.5 is not compatible with PHP 8.2
Comment #21
longwave9.5.x will be done in #3324544: Update dependencies for Drupal 9.5.0