Problem/Motivation

  1. Rework permission calculators
  2. Check overriding of chain calculator
  3. Update permission form
  4. Introduce tests

Issue fork group_permissions-3314382

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

LOBsTerr created an issue. See original summary.

finn lewis’s picture

finn lewis
Location Oxford
commented

Hi @LOBsTerr!

As I think you know, we're keen on this for LocalGov Drupal Microsites which uses this heavily. Ekes is working on other dependencies and I understand you might have already started work on this. We're keen to help wherever possible and test and get all the things working for our use case.

Do keep us posted on any progress and we'll also let you know how we're getting on.

Many thanks!

Finn

lobsterr’s picture

lobsterr commented

I have faced a very interesting question, what to do with admin roles. It was a case before.
Should we allow to override admin roles ?
Should we skip them ?

ekes’s picture

ekes commented

I'd guess you want to be able to assign admin roles per group?

lobsterr’s picture

lobsterr commented

@ekes You got it wrong.
Let's imagine we have created a few roles, which marked "as admin". It means these roles will have a full access and normally we can even change this role on Group type level.
My question is do we want to override admin roles? or we only what to override roles without admin access.

From one side, why do we want to override admin roles, if you have it you have full control, but from another side maybe it would be interesting to override these roles in some cases.

My idea to be as close as possible to group module. It means I prefer not to touch admin roles and even hide them on group permissions page.

ekes’s picture

ekes commented

So is_admin role are always is_admin role. Don't assign those roles in groups to users if you want to have different permissions per group for that role. Also makes sense.

lobsterr’s picture

lobsterr commented

ok, I will skip admin for a moment, we can add it at any moment, if it is required

LOBsTerr opened merge request !13

lobsterr’s picture

lobsterr commented
Status: Active » Fixed

I have finished to work on the first version. A good news we can use it for both Group 2.0 and Group 3.0, because we don't care about group cotent entity :) As I mentioned above we ignore admin roles.
I will prepare a new release. Please test it!

  • LOBsTerr committed 05b2e66 on 2.0.x 
    Issue #3314382 by LOBsTerr, Finn Lewis: Group permission 2.0 Roadmap

  • LOBsTerr committed 222eb5c on 2.0.x 
    Issue #3314382: Remove getRoles method.
finn lewis’s picture

finn lewis
Location Oxford
commented

Amazing, thanks LOBsTerr!

We can't currently test this against Group 3.x, as the composer.json is constrained to 2.x "drupal/group": "^2.0"

https://git.drupalcode.org/project/group_permissions/-/blob/2.0.x/compos...

Does this just need a quick change to something like : "drupal/group": "^2.0 || ^3.0 " ?

lobsterr’s picture

lobsterr commented

yes, my fault, I will fix it tomorrow

finn lewis’s picture

finn lewis
Location Oxford
commented

Thanks dude! I tried it on the issue fork. This allowed me to install it at least.

https://git.drupalcode.org/issue/group_permissions-3314382/-/commit/6134...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.