Create Support to work with Bootstrap 5

Thank you guys for your amazing job on this contribution

this produces placeholder bugs in the whole CMS

@juancec do you mind explaining better what's this "placeholder bugs in the whole CMS", please?

That's this "gray rectangle" in the screenshot?

Was placed in an "image editor" like Photoshop or is a layout bug after selects "Bootstrap 5" in the configuration? 🤔

That's the bug I'm talking about when I select "Bootstrap 5".

Got it. So I think we can move that to Needs Works because there is a probably to this "gray rectangle" appearing in another places that we didn't realize yet

I'd say that if it's very hard to fix and we don't find any solution for this I think we can analise if makes sense merge this current solution #3313638: Create Support to work with Bootstrap 5 and report this placeholder bug in a separated issue

@viniciuscosta @juancec , I was looking here and seems to be caused at this one: #3233533: Core .placeholder class conflicts with new Bootstrap .placeholder class

On this issue, in the comment #11 seems that there is an workaround

em.placeholder {
  display: unset;
  min-height: unset;
  vertical-align: unset;
  cursor: unset;
  background-color: unset;
  opacity: unset;
}

And in the Drupal project bootstrap5 it was fixed with that, look on this commit: https://git.drupalcode.org/project/bootstrap5/-/commit/670c44353a3a1b31c...

So, do you think we can try this same workaround?

If for any reason this workaround didn't work I think we can commit our issue to include the support to BS5 and explain that this issue with "placeholder" has the root cause at this issue

What do you think, makes sense for you?

Just as a "FYI", the same issue at #3246827: Fix em.placeholder style from Bootstrap 5 base styling with the Drupal core placeholder that was fixed with this commit

Awesome! Great job team!

I'll take a look and merge in the same plan of #3304464: Plan to Modal 5 (Drupal 10 Support)

Probably we'll merge first the #3288686: Automated Drupal 10 compatibility fixes and after that we'll merge this task in same version.

With that Modal 5 will supports D10 and BS5. Awesome

Thanks you so much everyone

I was going to merge this patch #24 but new fixes were commited into 4.1.x and was necessary to move these fixes to the new version 5.0.x

After merge 4.1.x into 5.0.x this patch #24 needs to be updated because some files were updated and can't be merged because of conflict

Now the branch 5.0.x is 100% equal the branch 4.0.x so I'm putting the tag "Needs reroll" and marking as "needs works". If this patch is updated just say here and we can merge for us in the sequence

Thank you so much team

Thanks a lot Vini. Great job

2 Points suggestions:

#1 early return and avoid "else", example:

From:

// Load Bootstrap Library only if necessary.
  if (!empty($loadBootstrap)) {
    $bootstrapVersion = $config->get('bootstrap_version');
    if (!isset($bootstrapVersion) || $bootstrapVersion == '3x') {
      $attachments['#attached']['library'][] = 'modal_page/modal-page-bootstrap-3';
    }
    else {
      $attachments['#attached']['library'][] = 'modal_page/modal-page-bootstrap-5';
    }
  }

to

 // Load Bootstrap Library only if necessary.
  if (empty($loadBootstrap)) {
    return;
  }

  $bootstrapVersion = $config->get('bootstrap_version');
  if (!isset($bootstrapVersion) || $bootstrapVersion == '3x') {
    $attachments['#attached']['library'][] = 'modal_page/modal-page-bootstrap-3';
    return;
  }

  $attachments['#attached']['library'][] = 'modal_page/modal-page-bootstrap-5';

}

#2 the hook update isn't working because the previous one is higher than the new one
previous: modal_page_update_400013 - new: modal_page_update_50001

To recognize we need to put modal_page_update_500001

P.S. These numbers are wrong, I think we can report a new ticket to solve that in the future. But for now I think we need to follow the sequence

Since the changes on #31 is quickly I did it here, follow the new patch with these fixes applied

Moved to the dev branch and kept the autor as @viniciuscosta

New version launched at https://www.drupal.org/project/modal_page/releases/5.0.0-beta3 where is saying thanks a lot to Vini and Juancec for your great job on this! You're rock!

Have a great weekend