Problem/Motivation

Great module thanks. After installing this module, any mailer policy entries that contained a mailer log element are deleted.

Steps to reproduce

  1. Install the module
  2. Add an element to the All/All policy as suggested on the project page
  3. Uninstall the module

Proposed resolution

Instead of removing the whole policy just remove the mail log element. Not sure how - Drupal seems to remove the policy automatically based on dependencies.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork symfony_mailer_log-3313407

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

AdamPS created an issue. See original summary.

phoang’s picture

phoang commented
Version: 1.0.0-alpha4 » 1.2.x-dev
Assigned: Unassigned » phoang
Status: Active » Needs review

phoang opened merge request !16

adamps’s picture

adamps commented

Thanks that looks sensible. I didn't test it as I don't have a suitable site at the moment however I reviewed the code.

svendecabooter made their first commit to this issue’s fork.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented

Tested and it works.

However, when uninstalling via the UI, you get a confirmation page that lists all config that will be uninstalled, and the mailer policies are still listed there... Not sure if we can circumvent that.
However, it's better to have them listed and not be deleted unwantedly, then the current state where they do get deleted.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

adamps’s picture

adamps commented

Great thanks. I agree with the point in #6, however potentially this is the best we can do given how Core works.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.