Problem/Motivation

Ukraine has 6817 towns, some of them has similar names,
so it's more comfortable for site owner and user to choose a region
and a town after that.

Proposed resolution

patch

CommentFileSizeAuthor
#2 commerce_novaposhta-3313199-2.patch12.72 KBvasyok
Regions-select-to-commerce_novaposhta-m-le.patch14.88 KBdunot

Issue fork commerce_novaposhta-3313199

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dunot created an issue. See original summary.

vasyok’s picture

vasyok commented
StatusFileSize
new commerce_novaposhta-3313199-2.patch12.72 KB

dunot, по-перше, дякую за цю неймовірну роботу 🤝.
Без патча вибір міста банально вішає браузер.
Взяв на себе сміливість трохи підкорегувати патч.
Сподіваюся автори внесуть цей код до наступної версії.

vasyok’s picture

vasyok commented

Схоже я трохи поспішив з деферамбами. Чисто технічно патч працює. Тобто вибір Область - місто у наявності. Але будь-які дії з налаштуванням поля Нової пошти призводять до unecpected error. Навіть інсталювання пропатченого модуля пише помилку у журнал.

Тип php

Drupal\Core\Config\UnsupportedDataTypeConfigException: Invalid data type in config commerce_novaposhta.schema, found in file modules/contrib/commerce_novaposhta/config/schema/commerce_novaposhta.schema.yml: yaml_parse(): parsing error encountered during parsing: did not find expected key (line 30, column 5), context while parsing a block mapping (line 24, column 3) in Drupal\Core\Config\FileStorage->read() (line 118 of /var/www/html/web/core/lib/Drupal/Core/Config/FileStorage.php).

Oleksandr Yushchenko made their first commit to this issue’s fork.

oleksandr yushchenko’s picture

oleksandr yushchenko commented
Assigned: dunot » oleksandr yushchenko
Status: Needs review » Needs work

Oleksandr Yushchenko opened merge request !10

oleksandr yushchenko’s picture

oleksandr yushchenko commented
Assigned: oleksandr yushchenko » Unassigned
Status: Needs work » Needs review

oleksandr yushchenko’s picture

oleksandr yushchenko commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dunot’s picture

dunot commented
Version: 2.0.x-dev » 2.1.0

Issue should be opened, because in version 2.1.0:
- at the stage of saving an order there are no regions
- therefore in the order viewing admin panel (in the column on the right) the city is repeated, and chosen region is absent.