FILE: /home/drupal/d9-open/scroll_top_button/js/scroll.top.button.js
------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 12 LINES
------------------------------------------------------------------------------------------------
  5 | ERROR | [x] Whitespace found at end of line
 12 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
 13 | ERROR | [x] Whitespace found at end of line
 16 | ERROR | [x] Whitespace found at end of line
 25 | ERROR | [x] Whitespace found at end of line
 31 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 39 | ERROR | [x] Whitespace found at end of line
 50 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 55 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 66 | ERROR | [x] Whitespace found at end of line
 69 | ERROR | [x] Whitespace found at end of line
 70 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------

Comments

Dharti Patel created an issue. See original summary.

dharti patel’s picture

Assigned: dharti patel » Unassigned
Status: Active » Needs review
StatusFileSize
new2.24 KB

Hello,

I have created a patch to fix this issue.
Kindly review the patch.

Thanks

Arturo-q’s picture

Assigned: Unassigned » Arturo-q

@Dharti Patel thanks for your patch, I will review it.

Arturo-q’s picture

Assigned: Arturo-q » Unassigned
Status: Needs review » Reviewed & tested by the community

Hey, I've applied the patch #1, and it fixes all the CS errors/warnings on the JS file.
Moving to RTBC.

  • 4907969 committed on 1.2.x
    Issue #3312292 by Dharti Patel: Phpcs coding standard issue
    

hemant bansal’s picture

Status: Reviewed & tested by the community » Fixed

Thank you all for your contribution!

hemant bansal’s picture

Status: Fixed » Closed (fixed)