Problem/Motivation

LocHub lately added webhook support for task update notification.

We can now create/update the webhooks for a selected LocHub project and ask to receive taskUpdated notifications. The module must expose an endpoint to receive the notifications and look for the change of status of the task to completed. This indicates the translation has been delivered and can be downloaded.

The documentation also states, that basic auth is supported.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 tmgmt_xillio-webhook-3312233-5.patch32.47 KBprimsi
#4 tmgmt_xillio-webhook-3312233-4.patch24.39 KBprimsi
#3 tmgmt_xillio-webhook-3312233-3.patch11.84 KBprimsi
#2 tmgmt_xillio-webhook-3312233-2.patch9.27 KBprimsi

Comments

Primsi created an issue. See original summary.

primsi’s picture

primsi commented
Status: Active » Needs review
StatusFileSize
new tmgmt_xillio-webhook-3312233-2.patch9.27 KB

Initial patch.

Parts, that might need some additional work:

  1. In the config form, we display the status, last message, and the url for the webhook. Maybe we want to improve the display there.
  2. The webhook id is stored in config. Not sure if this makes sense, I thought it's nice to know that it was already generated on this website. Then on the other side, it makes multi-environment life a bit harder
  3. The controller/route doesn't use the basic auth that webhooks support
primsi’s picture

primsi commented
StatusFileSize
new tmgmt_xillio-webhook-3312233-3.patch11.84 KB

Patch with all the files + renames.

primsi’s picture

primsi commented
StatusFileSize
new tmgmt_xillio-webhook-3312233-4.patch24.39 KB

Logo change.

primsi’s picture

primsi commented
StatusFileSize
new tmgmt_xillio-webhook-3312233-5.patch32.47 KB

Updated patch with smaller improvements and fixed some regressions.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Committed.

  • Berdir committed bd63c3b on 1.x 
    Issue #3312233 by Primsi: Support notification webhooks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.