Problem/Motivation

TypeError: Return value of Drupal\extra_field_plus\Plugin\ExtraFieldPlusDisplayManager::getFieldPlugin() must be an instance of Drupal\extra_field_plus\Plugin\ExtraFieldPlusDisplayInterface

Steps to reproduce

* Create extra_field fields without extra_field_plus

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 extra_field_plus-3309180-1.patch1.99 KBtobiasb

Issue fork extra_field_plus-3309180

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tobiasb created an issue. See original summary.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Active » Needs review
StatusFileSize
new extra_field_plus-3309180-1.patch1.99 KB
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil

Thank you @tobiasb! :) We'll have a look, thanks for the steps to reproduce!

@Grevil could you please have a look and try to reproduce this (and fix afterwards)? Thanks!

super_romeo’s picture

super_romeo commented

Patch #2 works.
Thank you, @tobiasb!

Grevil made their first commit to this issue’s fork.

grevil’s picture

grevil commented

Very nice! I will have a look shortly, just encountered a bug while installing "extra_field" #3315787: Class "DrupalCodeGenerator\Command\BaseGenerator" not found.

keshavv’s picture

keshavv commented
Status: Needs review » Reviewed & tested by the community

#2 patch solve the issue. +1 for RTBC.

grevil’s picture

grevil commented
Priority: Normal » Major

I could easily replicate this issue, quite major actually!

I'll have a look at the patch now.

Grevil opened merge request !19

grevil’s picture

grevil commented

LGTM!

Works as expected, just made the if cases a bit more explicit and adjusted the code a bit.

grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Needs review

Check https://git.drupalcode.org/project/extra_field_plus/-/merge_requests/19/... for a diff between the patch and my adjustments.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

@Grevil: Currently 6 tests seem to fail?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Left some comments.

grevil’s picture

grevil commented

@Anybody, D10 Tests are running for this module, even if it isn't Drupal 10 ready.

grevil’s picture

grevil commented
Status: Needs work » Reviewed & tested by the community

Tests all green! Let's merge this! Thanks, @tobiasb! Important find!

grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

  • Grevil committed 850f2dd0 on 3.x 
    Issue #3309180: TypeError: Return value of Drupal\extra_field_plus\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.