Problem/Motivation

This module is incompatible with Hux or any other module that decorates/overrides any of the services used in the formatters because the constructors are enforcing the concrete classes in core rather than the interfaces.

Steps to reproduce

Install hux and file_download_link

Proposed resolution

Type hint on the interface rather than the concrete class.

CommentFileSizeAuthor
#2 3308067-2.patch5.65 KBacbramley

Comments

acbramley created an issue. See original summary.

acbramley’s picture

acbramley commented
Status: Active » Needs review
StatusFileSize
new 3308067-2.patch5.65 KB
danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
Status: Needs review » Reviewed & tested by the community

Thanks for the issue, @acbramley!

The patch looks clean, the test pass, and this definitely fixes a whoopsie on my part. I'll commit this shortly.

  • danflanagan8 committed f349097 on 2.0.x 
    Issue #3308067 by acbramley: Formatter type hints should be interfaces
danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented

Committed. I'll put out a new release real quick because why not?

Thanks again!

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
Status: Reviewed & tested by the community » Fixed
acbramley’s picture

acbramley commented

@danflanagan8 thanks for the quick turnaround, appreciate it!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.