Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
According to #3222756: Allow using images from external source and #3272969: Remove unique constraint on block content info field our 9.4.4 database dump is wrong.
i.e. it contains configuration which can only match this 10.x-only issue #3257274: Implement color changing theme settings for Olivero.
Assuming these are actually 9.4.4 database dumps, the only way I can think of this happening is if the YAML file cache (which is PHP files) had some items from a 10.x install and they were read when dumping the database?
Last time we did an actual upgrade was in #3290810: Remove updates added prior to 9.4.0 (9.4.4 for ckeditor) and add 9.4.0 database dumps but it could have been introduced when we recreated the dumps in a removal issue.
Steps to reproduce
Proposed resolution
Load the 9.3.0 database dump, checkout Drupal 9.4.4, upgrade the database. Dump the database again and create a patch for 9.5.x
Then, still in 9.4.4 with the upgraded database, uninstall modules that are removed from 10.0.x (quickedit etc.), then dump the database again, and then create a patch for 10.1.x/10.0.x
Verify that the dumps don't re-introduce the same issue again, but applying one of the patches from the above two issues on top of the patch with the database dump in it and ensuring tests still pass.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #27 | 3306897-d10-27.patch | 1.07 MB | spokje |
| #24 | 3222756-with-9.4-php73-fixtures-for-realz.patch | 1.33 MB | spokje |
| #23 | 3306897-d95-23.patch | 1.33 MB | spokje |
Comments
Comment #2
catchComment #3
wim leersComment #4
spokjeComment #5
wim leers👏 @Spokje 🙏
Comment #6
spokjeComment #7
spokjeTurns out we need to replace both the bare and the filled fixture.
Comment #8
spokjeThe-Patch-That-Discovered-It-All (#3222756-85: Allow using images from external source, the 9.5 one) on top of the above new fixtures to (hopefully) show these dumps work.
Comment #9
spokjeNew fixtures (bare and filled) for
10.0.xare still needed according to @catch. I'm signing off for today, if nobody beats me to it, I'll have a look then.Comment #10
catchJust found #3306938: Restore olivero_post_update_add_olivero_primary_color() too (was wondering why the test for that issue wasn't failing, and it's because we removed the test).
Comment #11
spokjeRight, seems that these new fixtures didn't held up committing #3222756: Allow using images from external source...
Let's try that test with the new fixtures.
Comment #12
spokjeAlso let's try
3272969-15.patchwith the new 9.4.0 fixturesComment #13
spokjeComment #14
spokjeSomehow the new 9.5 fixtures seems to fail only on PHP 7.3 with a
Erroneous data format for unserializing 'Symfony\Component\Routing\Route'Comment #15
spokjeComment #16
catchThat is probably due to #3275093: Drupal 9.3.0 dumps were created with PHP 8, needs to be PHP 7.3.
Comment #17
spokjeBoth @catch and @quietone pointed out #3275093: Drupal 9.3.0 dumps were created with PHP 8, needs to be PHP 7.3 which seems to be the answer to the question in #14.
Comment #18
spokjeComment #19
spokjeComment #20
spokjeComment #21
wim leersIndeed, #3222756: Allow using images from external source was unblocked because we worked around this bug — see #3222756-89: Allow using images from external source for details. It's a harmless work-around; we didn't want to keep waiting even longer, especially because today the CKEditor 5 upstream release happens that will allow us to solve the last stable blockers! 🤓🥳
Comment #22
spokjeOk, the shortcut of importing and exporting the newly created fixtures using PHP7.3 didn't work.
Need to actually _recreate_ them in PHP 7.3.
Comment #23
spokjeHow about these then for
9.5.xComment #24
spokjeLet's have some proof
Comment #25
spokjeThe test failure on PHP7.3 & SQLite 3.28 seemed like a random one to me. Ordered a retest anyway.
Besides that: I think we might have hit on actual PHP 7.3-proof 9.4.0-fixtures for
9.5.xComment #26
spokjeLooking at the success rate of the automated tests for
PHP 7.3 & SQLite 3.28here: https://www.drupal.org/pift-ci-job/2464611, it looks like we have about 40% chance the test will return green.I'm not going to use more test-cycles to hit that 40%, seeing the other
PHP 7.3 & [insert_your_fav_DB_flavour_here]having passed, I hereby declare the9.5.x9.4.0-fixtures as good as I"m going to get them.Comment #27
spokjeComment #28
spokjeBoth the test failures on
pgsqlandsqliteseem random to me.Ordered a retest, but I'm pretty sure this can be NR until we await the return of the Get-A-Full-Testrun-Green-On-Anything-Else-But-MySQL.
Comment #29
spokjeLooking at the Automated testing of
PHP 8.1 & sqlite-3.27here: https://www.drupal.org/pift-ci-job/2465337, there's a 50/50 change of green. Not something I personally want to throw more test-cycles at.Comment #30
catch10.0.x dumps are validated in #3306938: Restore olivero_post_update_add_olivero_primary_color(), so I think we are probably ready to go here.
Comment #31
smustgrave commented@catch shared with me the sqlite failure ticket in https://www.drupal.org/project/drupal/issues/1120020. Since this seems to pass mysql and mariaDb fine with marking this RTBC to keep it moving.
Comment #32
alexpottCommitted and pushed d2bd120973 to 10.1.x and 01151f9313 to 10.0.x. Thanks!
Committed ebaa992 and pushed to 9.5.x. Thanks!
Comment #36
wim leersWow, you made this happen in record time, @Spokje! 👏