Problem/Motivation

In order to #3267267: [Meta] Tasks to deprecate RDF we need a subtree split from core and a stable release. Lets work on that here.

Steps to reproduce

na

Proposed resolution

Create a subtree split
Investigate if we need a orphan branch or we can just add history on top
Make sure tests work
Make sure including the module in core works
Mark older branches and releases unsupported if needed
Profit.

Remaining tasks

Create a subtree split
Investigate if we need a orphan branch or we can just add history on top
Make sure tests work
Make sure including the module in core works
Mark older branches and releases unsupported if needed

User interface changes

None

API changes

n.a.

Data model changes

n.a.

Release notes snippet

tbd

Issue fork rdf-3306737

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

bbrala created an issue. See original summary.

bbrala’s picture

Version: 7.x-2.x-dev » 1.x-dev

Retarget to 1.x

bbrala’s picture

Ok, i accidentally screwed up the 1.x branch. I've created a 2.x branch in the main module and did the following:

  1. Full split from core with history.
  2. Changed rdf.info.yml to set correct package
  3. Changed rdf.info.yml to add support for right Drupal versions
  4. Added a composer.json with basic info

Then i tested by doing the following (this is part of my local install script for development :x):

DRUPAL_PROJECT=rdf
DRUPAL_PROJECT_PATH=rdf

cd /home/localcopy
git clone git@git.drupal.org:project/rdf
cd rdf
git switch 2.x
cd ..
composer create-project drupal/recommended-project drupal-module-rdf 9.5.x-dev --no-install
cd drupal-module-rdf
composer config minimum-stability dev
composer config repositories.rdf path "/home/localcopy/rdf"
composer require --dev drupal/core-dev:9.5.x-dev --no-install
composer require --dev phpspec/prophecy-phpunit:^2 -W
composer require drupal/rdf --no-install
composer require drush/drush --no-install
composer install
vendor/bin/drush --yes site:install standard \
    install_configure_form.site_default_country=NL \
    install_configure_form.date_default_timezone=Europe/Amsterdam \
    install_configure_form.enable_update_status_module=1 \
    install_configure_form.enable_update_status_emails=NULL \
    --locale="en" \
    --site-name="Project rdf development" \
    --site-mail="bjorn@swis.nl" \
    --account-name="root" \
    --account-pass="root" \
    --account-mail="bjorn@swis.nl" \
	  --db-url="mysql://root:root@localhost/drupal_module_rdf"
cp web/core/phpunit.xml.dist web/core/phpunit.xml
#change all phpunit.xml to the rights paths and database and such

pushd web
drush en -y rdf
drush cr
../vendor/bin/phpunit -c core/phpunit.xml modules/contrib/rdf/tests/ --stop-on-failure

I tested if RDF stuff came up in the code as expected. It did.

Also i ran tests in the contrib install.

vagrant@1WNLK63:/home/localcopy/drupal-module-rdf/web $ ../vendor/bin/phpunit -c core/phpunit.xml modules/contrib/rdf/tests/ --stop-on-failure
HTML output directory ../sites/simpletest/browser_output is not a writable directory.
PHPUnit 9.5.24 #StandWithUkraine

Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

Testing /home/localcopy/rdf/tests
...........SSSSSS........SSS.SSS.SSS.SSS.SSS.SSS................. 65 / 82 ( 79%)
.................                                                 82 / 82 (100%)

Time: 04:34.518, Memory: 24.00 MB

OK, but incomplete, skipped, or risky tests!
Tests: 82, Assertions: 1876, Skipped: 24.

So it seems the 2.x branch is fully working as expected :)

bbrala’s picture

Issue summary: View changes

bbrala’s picture

Status: Active » Needs review
bbrala’s picture

Version: 1.x-dev » 2.x-dev

bbrala’s picture

Well, the mr is confused. Here is the link to the test on the 2.x branch: pift-ci-job/2464169

phenaproxima’s picture

I checked out the 2.x branch locally, into my checkout of Drupal core 10.1.x HEAD, and ran all tests. They passed 🎉

One thing I notice: composer.json defines a dependency on core ^9 || ^10. But rdf.info.yml is more specific: ^9.5 || ^10. We should probably drop the constraint from composer.json entirely and rely on the info file, no? Or at least we should make sure these match. (Really, couldn't we just remove composer.json entirely? There doesn't appear to be anything in there that packages.drupal.org won't put there automatically.)

But, while I'm thinking about it: why would we ever want people to install this module on Drupal 9, any version? Won't it conflict with the core RDF module? Should we change the constraints to ^10 only?

bbrala’s picture

Yeah I agree, but I need the composer.json for testbot to be able to do anything I think and I think to be able to require it as a path repo? Rather have none though, but rather remove it from a follow up.

In the end the requirements are based on drupals composer repo which uses the info file for core requirements.

So, I'll at least change it to be fully consistent and open a follow-up to remove.

bbrala’s picture

Hmm, adding to that. We need a 9.4 pr 9.5 also, since that makes the upgrade a lot easier. You can upgrade the module before upgrading to 10. Which is helpfull.

  • bbrala committed de8ca8f on 2.x
    Make sure composer.json and info.yml are consistent as per feedback in...
bbrala’s picture

Status: Needs review » Fixed

Committed and released 2.0.0.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.