Problem/Motivation

Naming the flourish entity in the CMS so it can easily be found in the media library might not give the most useful aria label, and can cause confusion for users using a screen reader.

Proposed resolution

Remove the aria-label attribute altogether. On div's, it's not recommended to use it without an accompanying role https://w3c.github.io/using-aria/#well-supported-elements and flourish provides other accessibility such as title on the iframe, as well as a text field to describe the graph (see: https://flourish.studio/blog/accessible-visualization-screenreader-descr... ). I think these will provide enough information.

Comments

LachlanJ created an issue. See original summary.

lachlanj’s picture

StatusFileSize
new510 bytes

Mini patch

lachlanj’s picture

Status: Active » Needs review
mortim07’s picture

StatusFileSize
new5 KB

@LachlanJ Instead I've created a new field item property for adding a description that can be used in favour of the media title. If this isn't provided it then defaults back to the media title.

mortim07’s picture

StatusFileSize
new5.11 KB

Updated patch to include description for the description property within the field widget.

mortim07’s picture

StatusFileSize
new10.16 KB

I've updated the patch to fix the tests.

mortim07’s picture

StatusFileSize
new9.85 KB
lachlanj’s picture

Looks good to me!

lachlanj’s picture

Status: Needs review » Reviewed & tested by the community

  • mortim07 committed ab655a67 on 1.x
    Issue #3305930 by mortim07, LachlanJ: Using entity title for aria-label...
mortim07’s picture

Version: 1.0.0-beta2 » 1.0.0-beta4
Status: Reviewed & tested by the community » Fixed
mortim07’s picture

Status: Fixed » Closed (fixed)