Problem/Motivation
Naming the flourish entity in the CMS so it can easily be found in the media library might not give the most useful aria label, and can cause confusion for users using a screen reader.
Proposed resolution
Remove the aria-label attribute altogether. On div's, it's not recommended to use it without an accompanying role https://w3c.github.io/using-aria/#well-supported-elements and flourish provides other accessibility such as title on the iframe, as well as a text field to describe the graph (see: https://flourish.studio/blog/accessible-visualization-screenreader-descr... ). I think these will provide enough information.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 3305930-7.patch | 9.85 KB | mortim07 |
| #5 | media_entity_flourish-3305930.patch | 5.11 KB | mortim07 |
| #4 | media_entity_flourish-3305930.patch | 5 KB | mortim07 |
| #2 | 3305930-aria-label.patch | 510 bytes | lachlanj |
Comments
Comment #2
lachlanj commentedMini patch
Comment #3
lachlanj commentedComment #4
mortim07 commented@LachlanJ Instead I've created a new field item property for adding a description that can be used in favour of the media title. If this isn't provided it then defaults back to the media title.
Comment #5
mortim07 commentedUpdated patch to include description for the description property within the field widget.
Comment #6
mortim07 commentedI've updated the patch to fix the tests.
Comment #7
mortim07 commentedComment #8
lachlanj commentedLooks good to me!
Comment #9
lachlanj commentedComment #11
mortim07 commentedComment #12
mortim07 commented