Problem/Motivation

Currently the module's settings configuration form is restricted by the 'access administration pages' permission.

Proposed resolution

Introduce a 'administer layout builder direct add settings' permission

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

joewhitsitt created an issue. See original summary.

RedwanJamous made their first commit to this issue’s fork.

redwan jamous’s picture

Assigned: Unassigned » redwan jamous
Status: Active » Needs review

Created a merge request that adds a new permission to restrict the access to the configuration page.

pyrello’s picture

Status: Needs review » Needs work

I would like to see a test added to ensure that the page cannot be viewed unless the user has the new permission. We are starting to add tests in https://www.drupal.org/project/lb_direct_add/issues/3203657 and moving forward that is going to be part of how we add new functionality.

pyrello’s picture

It looks like there are docs pages that cover exactly this type of test: https://www.drupal.org/project/lb_direct_add/issues/3305765

pyrello’s picture

@RedwanJamous Any chance you are able to whip up a test for this? I'm working on getting a 2.0 release ready and we could get this in with a test.

pyrello’s picture

Issue tags: +Needs tests

Marking this as needs tests. Other than that, this is good to go.

pyrello’s picture

Status: Needs work » Reviewed & tested by the community

I tested this and tests are also passing.

  • pyrello committed 13db5f3 on 2.x authored by RedwanJamous
    Issue #3305765 by pyrello, RedwanJamous: Add module specific permission...
pyrello’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.