Problem/Motivation
Currently the module's settings configuration form is restricted by the 'access administration pages' permission.
Proposed resolution
Introduce a 'administer layout builder direct add settings' permission
Issue fork lb_direct_add-3305765
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
redwan jamous commentedCreated a merge request that adds a new permission to restrict the access to the configuration page.
Comment #5
pyrello commentedI would like to see a test added to ensure that the page cannot be viewed unless the user has the new permission. We are starting to add tests in https://www.drupal.org/project/lb_direct_add/issues/3203657 and moving forward that is going to be part of how we add new functionality.
Comment #6
pyrello commentedIt looks like there are docs pages that cover exactly this type of test: https://www.drupal.org/project/lb_direct_add/issues/3305765
Comment #7
pyrello commented@RedwanJamous Any chance you are able to whip up a test for this? I'm working on getting a 2.0 release ready and we could get this in with a test.
Comment #8
pyrello commentedMarking this as needs tests. Other than that, this is good to go.
Comment #9
pyrello commentedI tested this and tests are also passing.
Comment #11
pyrello commented