Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
Umami depends on Seven, via umami.libraries.yml:
demo-umami-tour:
css:
theme:
css/components/tour/tour.theme.css: {}
dependencies:
- seven/tour-styling
Steps to reproduce
Proposed resolution
Remove the dependency.
Remaining tasks
Figure out how to remove it.
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | core-3304655-5.patch | 494 bytes | _shy |
Comments
Comment #2
longwaveNow critical given that #3084814: Deprecate Seven theme already landed.
Comment #3
catch#3087701: Enable Claro as the admin theme in Umami landed months ago now. Does the dependency just silently fail when it's not there?
Comment #4
catchThree options:
1. Change the dependency to
claro.tour-styling2. Copy the CSS from Seven to Umami
3. Remove the dependency if it's not really needed.
Overall though I don't know why Umami's front-end theme is depending on an admin theme, I guess for a demo it's fine but there's no guarantee it'll be installed given the theme doesn't have a hard dependency in .info.yml
Comment #5
_shyReplaced the dependency to
claro/tour-stylingaccording to the option 1 from the comment #4.Comment #6
_shyComment #8
lauriiiThis is super funky because Claro is not the active theme when Umami theme is the active theme. What is even more funky is that this works even when Claro is not install. 🤯 The asset system is not checking whether a theme is enabled or not, and there is no warning in this case as long as the extension exists. Since Claro is in core, it is guaranteed to exist.
I don't think this is ideal but this is fine. This is certainly better than the case where Seven is removed and asset system would trigger a warning for a missing extension dependency because it cannot resolve
seveninto anything unless its downloaded from contrib.Comment #9
wim leersI've long been wanting to add many more sanity checks/assertions to the asset library system. It barely has any 😔 (For historical reasons, and IIRC to avoid causing disruption.)
See #2231385: Verify that the library files exist for at least one of those issues.
Comment #11
catchCommitted/pushed to 10.1.x and 10.0.x, thanks!
I'm now wondering if we even want to do this for 9.5.x - i.e. it might be a visual change so should we leave it alone given Seven is available and this doesn't trigger any deprecation errors? Back to CNR but can just cherry-pick if we do after all.
Comment #13
lauriiiIMO we should depend on the Claro styles there too since Umami uses Claro by default. I tested the styles and they looked okay with both, Seven and Claro.
Comment #15
catchOK that makes sense, cherry-picked to 9.5.x too.