This issue is created to separately track the D10 compatibility so that actions here does not interfere with the automated patches at https://www.drupal.org/project/comment_approver/issues/3286594

As part of this issue:

Creating a new D10 compatible branch 2.x
Add the necessary changes in the codebase to support d10 release.

Remaining

  • Testing the module with drupal 10 compatible version of purge module.
  • Creating a stable tagged release for d10 version.
CommentFileSizeAuthor
#4 3300681-3.patch2.38 KBguptahemant

Comments

guptahemant created an issue. See original summary.

guptahemant’s picture

guptahemant commented
Issue summary: View changes
guptahemant’s picture

guptahemant commented

Verified the patch from https://www.drupal.org/project/comment_approver/issues/3286594#comment-1...

ddev drush upgrade_status:analyze comment_approver
 [notice] Processing /var/www/html/web/modules/contrib/comment_approver.

================================================================================
Comment approver, --
Scanned on Fri, 07/29/2022 - 11:30

No known issues found.

Manual testing on drupal 9
- Working correctly

guptahemant’s picture

guptahemant commented
StatusFileSize
new 3300681-3.patch2.38 KB

https://www.drupal.org/node/3159012 - Just stumble on this while working testing on D10, Drupal update status and Automated patch is not capturing the event dispatch argument order change, Adding an updated patch.

  • guptahemant committed 841d8ef on 2.x 
    Issue #3300681 by guptahemant: Update module for D10 readiness
guptahemant’s picture

guptahemant commented

Verified with drupal 10 alpha version, working correctly hence code is committed on 2.x branch.

guptahemant’s picture

guptahemant commented
Assigned: guptahemant » Unassigned
Issue summary: View changes
Status: Active » Fixed

Created the release

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Related issues: +#3286594: Automated Drupal 10 compatibility fixes

Thanks for participating in porting day! Glad you got this fixed :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.