This issue is created for D10 compatibility of the module to provide manual patches in separation to https://www.drupal.org/project/zurb_template/issues/3299572 that has got automated patches from the project bot.

CommentFileSizeAuthor
#10 interdiff_2-3.txt592 bytesfathima.asmat
#8 zurb-template-d10-readiness-once-fixed-3300661-3.patch6.84 KBfathima.asmat
#2 zurb-template-d10-readiness-3300661-2.patch7.19 KBfathima.asmat

Comments

fathima.asmat created an issue. See original summary.

fathima.asmat’s picture

fathima.asmat commented
StatusFileSize
new zurb-template-d10-readiness-3300661-2.patch7.19 KB

A patch is attached here with the fixes for issues raised by upgrade status module. After the patch is applied, upgrade status module produces a clean report:

drush upgrade_status:analyze zurb_template
 [notice] Processing /var/www/html/web/themes/contrib/zurb_template.

================================================================================
ZURB Template, --
Scanned on Fri, 07/29/2022 - 09:47

No known issues found.
fathima.asmat’s picture

fathima.asmat commented
Status: Active » Needs review
fathima.asmat’s picture

fathima.asmat commented
Related issues: +#3299572: Automated Drupal 10 compatibility fixes
atul_ghate’s picture

atul_ghate commented
Assigned: Unassigned » atul_ghate

Hi,
i will review this patch.

atul_ghate’s picture

atul_ghate commented
Assigned: atul_ghate » Unassigned

Hello,
This theme was successfully installed on drupal 10 with no log messages after applying the patch provided, and I also checked by using upgrade status module on drupal 9 and it was successfully installed with no log messages . It can now be moved onto RTBC.

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
Status: Needs review » Needs work 
+++ b/zurb_template.libraries.yml
@@ -7,6 +7,7 @@ global:
+    https://cdnjs.cloudflare.com/ajax/libs/jquery-once/2.2.3/jquery.once.min.js: { type: external, minified: true }

We probably want to use the core provided once library implementation instead (drupal/once).

Assuming users are able to load CDN content isn't advisable due to CSP's, national firewalls, etc.

Setting back to NW.

fathima.asmat’s picture

fathima.asmat commented
StatusFileSize
new zurb-template-d10-readiness-once-fixed-3300661-3.patch6.84 KB

jQuery once swapped with core/once. Patch updated. Checked the JS files individually for once usage, however, there wasn't any that needed updating with core/once usage callbacks.

fathima.asmat’s picture

fathima.asmat commented
Status: Needs work » Needs review
fathima.asmat’s picture

fathima.asmat commented
StatusFileSize
new interdiff_2-3.txt592 bytes

Interdiff attached.

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented

Performed basic sanity testing with #8 on 10.0.x-dev and didn't encounter any fatal errors.

Unfortunately, I'm not intimately familiar with this theme, so I can't mark as RTBC.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Title: Drupal10 readiness » Drupal 10 readiness
Issue tags: +Needs manual testing

Thanks everyone for participating in porting day! Tagging for manual testing :)

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Working during porting day.

This still needs testing.

andyg5000’s picture

andyg5000
Primary language English
Location North Carolina, USA
commented
Status: Needs review » Fixed

Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.