Problem/Motivation

There's currently an issue with the FastlyEdgeModulesController which specifies the FileSystem service itself directly, instead of its interface.

As a consequence, when the file system service is decorated (For example, when using the S3FS module), the following error occurs:

TypeError: Drupal\fastly\Controller\FastlyEdgeModulesController::__construct(): Argument #3 ($file_system) must be of type Drupal\Core\File\FileSystem, Drupal\s3fs\S3fsFileService given.

The fix consists in using the FilesystemInteface instead, patch to follow.

CommentFileSizeAuthor
#2 3300636-2.patch1.99 KBjsacksick

Issue fork fastly-3300636

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jsacksick created an issue. See original summary.

jsacksick’s picture

jsacksick commented
Status: Active » Needs review
StatusFileSize
new 3300636-2.patch1.99 KB

Jaykumar95 made their first commit to this issue’s fork.

Jaykumar95 opened merge request !9

jsacksick’s picture

jsacksick commented

@Jaykumar95: Why are you opening a merge request?

Jaykumar95 opened merge request !10

jaykumar95’s picture

jaykumar95
Primary language English
Location Ahmedabad
commented

@jsacksick do I close it then?

jsacksick’s picture

jsacksick commented

@Jaykumar95: I submitted a patch before your merge request, so not sure what is the point of opening a merge request when there's already a patch?

Jaykumar95 closed merge request !10

b_sharpe’s picture

b_sharpe commented
Status: Needs review » Reviewed & tested by the community

Fixes issue, straight forward and cleans up standards as well, RTBC

xsdx’s picture

xsdx commented

Checked and looks ok to me.

  • xSDx committed 64593e48 on 8.x-3.x authored by jsacksick 
    Issue #3300636: Errors when the filesystem service is decorated
jsacksick’s picture

jsacksick commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.