need to add hook_help() function in .module file. and remove unwanted function

CommentFileSizeAuthor
#11 30.12.2022_19.00.16_REC.png13.92 KBcharchil khandelwal
#8 3299696-8.patch1.33 KBheni_deepak
#5 patch-applied-cleanly.png69.55 KBanoopsingh92
#2 Unused-variable-3299696-2.patch449 bytesHarsh panchal

Issue fork files_upload-3299696

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Harsh panchal created an issue. See original summary.

Harsh panchal’s picture

Harsh panchal commented
Category: Task » Bug report
Status: Active » Needs review
StatusFileSize
new Unused-variable-3299696-2.patch449 bytes

I have fixed this and providing a patch.

anoopsingh92 made their first commit to this issue’s fork.

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Assigned: Harsh panchal » anoopsingh92
anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Assigned: anoopsingh92 » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new patch-applied-cleanly.png69.55 KB

Hi @Harsh, Your patch was applied cleanly. It is working fine for me.

Lenovo@LAPTOP-PDE747K8 MINGW64 /c/xampp/htdocs/drupal-9/web/modules/contrib/files_upload-3299696 (1.0.0)
$ git apply -v Unused-variable-3299696-2.patch
Checking patch files_upload.module...
Applied patch files_upload.module cleanly.

Thanks for the patch. Moving it to RTBC.

heni_deepak’s picture

heni_deepak commented
Title: Unused variable $route_name. » need to add hook_help() in module file
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

need to replaced hook_form_alter() to hook_help()
So i will change the issue summery and mark as need work.

heni_deepak’s picture

heni_deepak commented
Issue summary: View changes

@ Harsh panchal thanks for notify me.

heni_deepak’s picture

heni_deepak commented
StatusFileSize
new 3299696-8.patch1.33 KB

I have added reference patch. please review.

heni_deepak’s picture

heni_deepak commented
Status: Needs work » Needs review

heni_deepak opened merge request !4

charchil khandelwal’s picture

charchil khandelwal commented
StatusFileSize
new 30.12.2022_19.00.16_REC.png13.92 KB

Patch #8 tested and applied successfully.

jay jangid’s picture

jay jangid commented
Assigned: Unassigned » jay jangid

I will review this patch.

jay jangid’s picture

jay jangid commented
Assigned: jay jangid » Unassigned

Patch #8 working successfully.
Result:-Add hook_help() in module file.
Thank you.

Sonal Gyanani made their first commit to this issue’s fork.

Sonal Gyanani’s picture

Sonal Gyanani commented
Status: Needs review » Reviewed & tested by the community
Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Reviewed & tested by the community » Needs review

Thanks @Sonal Gyanani, your new MR!4 probably needs to be reviewed by someone else, to change status to RTBC.

Manoj Raj.R’s picture

Manoj Raj.R commented

hook_help() Looks good to me. Nice catch and providing hook_help instead of hook_form_alter.

LGTM

+1 RTBC

jay jangid’s picture

jay jangid commented
Status: Needs review » Reviewed & tested by the community

Thanks @Sonal Gyanani for new MR 4.
Looks good to me.
Moving to RTBC +.

  • heni_deepak committed f740fc6b on 1.0.x 
    Issue #3299696: need to add hook_help() in module file
heni_deepak’s picture

heni_deepak commented
Status: Reviewed & tested by the community » Fixed

Thanks @all

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.